Skip to content

clang-format job on Buildkite is bogus #66468

@asl

Description

@asl
Collaborator

Consider e.g. https://buildkite.com/llvm-project/clang-ci/builds/3190#018a97ac-63f5-4517-ae31-3f185df940ae
clang-format job failed, however, there is no way to figure out what is wrong: the output is simply missed from the log.

Activity

added
bugIndicates an unexpected problem or unintended behavior
infrastructureBugs about LLVM infrastructure
on Sep 15, 2023
llvmbot

llvmbot commented on Sep 15, 2023

@llvmbot
Member

@llvm/issue-subscribers-bug

Consider e.g. https://buildkite.com/llvm-project/clang-ci/builds/3190#018a97ac-63f5-4517-ae31-3f185df940ae clang-format job failed, however, there is no way to figure out what is wrong: the output is simply missed from the log.
llvmbot

llvmbot commented on Sep 15, 2023

@llvmbot
Member

@llvm/issue-subscribers-infrastructure

Consider e.g. https://buildkite.com/llvm-project/clang-ci/builds/3190#018a97ac-63f5-4517-ae31-3f185df940ae clang-format job failed, however, there is no way to figure out what is wrong: the output is simply missed from the log.
added
libc++libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
and removed on Sep 15, 2023
metaflow

metaflow commented on Sep 15, 2023

@metaflow
Contributor

@ldionne could you please take a look?

added a commit that references this issue on Sep 15, 2023
46330c2
assigned and unassigned on Sep 15, 2023
ldionne

ldionne commented on Sep 15, 2023

@ldionne
Member

Actually, I'll assign this to @tru since he's made a lot of progress on setting up clang-format for the whole monorepo. That will replace the Buildkite job we have for Clang.

asl

asl commented on Sep 15, 2023

@asl
CollaboratorAuthor

Will you please disable the job now as it simply makes everything else fail?

removed
libc++libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
on Sep 15, 2023
ldionne

ldionne commented on Sep 15, 2023

@ldionne
Member

a52560c

The issue is that someone (you?) added trailing whitespace. The job output isn't great, but it does say:

grep -rnI '[[:blank:]] clang/lib clang/include clang/docs
clang/lib/CodeGen/CGCoroutine.cpp:836:
asl

asl commented on Sep 15, 2023

@asl
CollaboratorAuthor

grep -rnI '[[:blank:]] clang/lib clang/include clang/docs
clang/lib/CodeGen/CGCoroutine.cpp:836:

And how one could deduce that this is something related to the failure? And not just some part of job script? Especially given that line 69 is absent from the log and one could clearly expect to see the error there (after ":" on the line above). Certainly, it is clear what is going on to whoever written this script, but for everyone else the output is very confusing. I spent quite some time trying to find the error message in various parts of the system including raw logs, etc.

That said, is it possible to annotate steps somehow? Is it possible to provide some error messages instead of just user command error: exit status 1?

added a commit that references this issue on Sep 18, 2023
df20b63
assigned and unassigned on Sep 19, 2023
added a commit that references this issue on Sep 19, 2023
6af2674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugIndicates an unexpected problem or unintended behaviorinfrastructureBugs about LLVM infrastructure

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @tru@asl@metaflow@ldionne@owenca

    Issue actions

      clang-format job on Buildkite is bogus · Issue #66468 · llvm/llvm-project