-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[libc++] __cpp_lib_ranges is defined without all views being available #70557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I am not sure how difficult this can be, but if there is some instruction I would like to take this one. |
I would suggest closing this without any resolution -- we're about to take |
Maybe related: |
I have just run into this 😭 I previously had: #if defined(__cpp_lib_ranges) && __cpp_lib_ranges >= 202202L
template <typename T>
using range_adaptor_closure = std::ranges::range_adaptor_closure<T>;
#elif defined(__GLIBCXX__)
template <typename T>
requires(std::is_class_v<T> && std::same_as<T, std::remove_cv_t<T>>)
struct range_adaptor_closure : std::ranges::views::__adaptor::_RangeAdaptorClosure
{};
#elif defined(_LIBCPP_VERSION)
template <typename T>
using range_adaptor_closure = std::__range_adaptor_closure<T>;
#else
# error "Requires modern standard library or older libstdc++ or libc++."
#endif Now, I will need to add more checks... |
Closing, since join_view isn't experimental anymore. |
Work around triggering of bug in libc++ <19. error: no template named 'range_adaptor_closure' in namespace 'std::ranges'; did you mean 'std::__range_adaptor_closure'? ranges::range_adaptor_closure is not implemented in libc++ <19 (despite the __cpp_lib_ranges feature check macro claiming otherwise): llvm/llvm-project#70557 (comment)
Work around triggering of bug in libc++ <19. error: no template named 'range_adaptor_closure' in namespace 'std::ranges'; did you mean 'std::__range_adaptor_closure'? ranges::range_adaptor_closure is not implemented in libc++ <19 (despite the __cpp_lib_ranges feature check macro claiming otherwise): llvm/llvm-project#70557 (comment)
We've but
views::join
behind_LIBCPP_ENABLE_EXPERIMENTAL
, but we didn't put__cpp_lib_ranges
behind_LIBCPP_ENABLE_EXPERIMENTAL
.The text was updated successfully, but these errors were encountered: