Skip to content

modules;json: inconsistent keys: is-standard-library vs is-std-library #82879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mathstuf opened this issue Feb 24, 2024 · 1 comment · Fixed by #83036
Closed

modules;json: inconsistent keys: is-standard-library vs is-std-library #82879

mathstuf opened this issue Feb 24, 2024 · 1 comment · Fixed by #83036
Assignees
@mordante
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Milestone
LLVM 18.X Release

Comments

@mathstuf
Copy link
Contributor

@mordante In libc++.modules.json, there are two spellings for "is this a standard library module": is-standard-library and is-std-library. This should be resolved before 18.0.0 is released. Introduced in #75741.

Pinging release managers to get this marked as a blocker for 18.0: @llvm/llvm-release-managers
@EugeneZelenko EugeneZelenko added libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. and removed new issue labels Feb 24, 2024
@EugeneZelenko EugeneZelenko added this to the LLVM 18.X Release milestone Feb 24, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Feb 24, 2024
@mordante mordante self-assigned this Feb 25, 2024
@mordante mordante mentioned this issue Feb 26, 2024
Merged
mordante added a commit to mordante/llvm-project that referenced this issue Feb 26, 2024
@mordante
[libc++][modules] Fixes naming inconsistency.
42046e3 
The modules used is-standard-library and is-std-library. The latter is
the name used in the SG15 proposal,

Fixes: llvm#82879
@tstellar tstellar moved this from Needs Triage to Needs Fix in LLVM Release Status Feb 26, 2024
ldionne pushed a commit that referenced this issue Feb 27, 2024
@mordante
[libc++][modules] Fixes naming inconsistency. (#83036)
b50bcc7 
The modules used is-standard-library and is-std-library. The latter is
the name used in the SG15 proposal,

Fixes: #82879
@github-project-automation github-project-automation bot moved this from Needs Fix to Done in LLVM Release Status Feb 27, 2024
llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Feb 27, 2024
@mordante @llvmbot
[libc++][modules] Fixes naming inconsistency. (llvm#83036)
7cab6b8 
The modules used is-standard-library and is-std-library. The latter is
the name used in the SG15 proposal,

Fixes: llvm#82879
(cherry picked from commit b50bcc7)
llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Mar 11, 2024
@mordante @tstellar
[libc++][modules] Fixes naming inconsistency. (llvm#83036)
439e6f8 
The modules used is-standard-library and is-std-library. The latter is
the name used in the SG15 proposal,

Fixes: llvm#82879
(cherry picked from commit b50bcc7)
@mordante
Copy link
Member

@mathstuf actually it seems I copied this correctly. The proposal on the SG15 reflector uses both. (I'll mail the reflector.)

blueboxd pushed a commit to blueboxd/libcxx that referenced this issue May 4, 2024
@mordante @copybara-github
[libc++][modules] Fixes naming inconsistency. (#83036)
38a110a 
The modules used is-standard-library and is-std-library. The latter is
the name used in the SG15 proposal,

Fixes: llvm/llvm-project#82879
NOKEYCHECK=True
GitOrigin-RevId: b50bcc7ffb6ad6caa4c141a22915ab59f725b7ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mordante mordante

Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 18.X Release
Development

Successfully merging a pull request may close this issue.

[libc++][modules] Fixes naming inconsistency. mordante/llvm-project
3 participants
@mathstuf @mordante @EugeneZelenko