Skip to content

[DSE] crash #84051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JonPsson1 opened this issue Mar 5, 2024 · 4 comments · Fixed by #84157
Closed

[DSE] crash #84051

JonPsson1 opened this issue Mar 5, 2024 · 4 comments · Fixed by #84157
Labels
crash-on-valid llvm:transforms release:backport
Milestone
LLVM 18.X Release

Comments

@JonPsson1
Copy link
Contributor

Reduced test case:
tc_dse.tar.gz

opt -mtriple=s390x-unknown-linux -mcpu=z16 -O3 -S ./tc_dse.ll

#6 0x0000000005287456 llvm::BasicAAResult::aliasCheck
#11 0x00000000048f0646 (anonymous namespace)::DSEState::isReadClobber
14 0x00000000049004d8 llvm::DSEPass::run
Segmentation fault (core dumped)

This is reported by user on F37 with clang-15, and is still failing on trunk.

@fhahn @BK1603 @nikic
@nikic
Copy link
Contributor

nikic commented Mar 6, 2024

llvm-reduce result for -passes=dse: https://gist.github.com/nikic/d52c888425c5d4ff3fbd37b4f84778b6

valgrind reports a use-after-free. Probably not invalidating EII correctly somewhere.

@fhahn
Copy link
Contributor

fhahn commented Mar 6, 2024

Also reproduces with ASAn, looking now

fhahn added a commit to fhahn/llvm-project that referenced this issue Mar 6, 2024
@fhahn
[DSE] Remove malloc from EarliestEscapeInfo before removing.
9ad27a4 
Not removing the malloc from earliest escape info leaves stale entries
in the cache.

Fixes llvm#84051.
@fhahn fhahn mentioned this issue Mar 6, 2024
Merged
fhahn added a commit that referenced this issue Mar 6, 2024
@fhahn
[DSE] Remove malloc from EarliestEscapeInfo before removing. (#84157)
eb8f379 
Not removing the malloc from earliest escape info leaves stale entries
in the cache.

Fixes #84051.

PR: #84157
@fhahn fhahn mentioned this issue Mar 6, 2024
Merged
fhahn added a commit to swiftlang/llvm-project that referenced this issue Mar 7, 2024
@fhahn
[DSE] Remove malloc from EarliestEscapeInfo before removing. (llvm#84157
e72f197 
)

Not removing the malloc from earliest escape info leaves stale entries
in the cache.

Fixes llvm#84051.

PR: llvm#84157

(cherry-picked from eb8f379)
@nikic nikic added this to the LLVM 18.X Release milestone Mar 12, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Mar 12, 2024
@nikic
Copy link
Contributor

nikic commented Mar 12, 2024

/cherry-pick eb8f379

llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Mar 12, 2024
@fhahn @llvmbot
[DSE] Remove malloc from EarliestEscapeInfo before removing. (llvm#84157
b185008 
)

Not removing the malloc from earliest escape info leaves stale entries
in the cache.

Fixes llvm#84051.

PR: llvm#84157
(cherry picked from commit eb8f379)
@llvmbot
Copy link
Member

llvmbot commented Mar 12, 2024

/pull-request #84946

@nikic nikic moved this from Needs Triage to Done in LLVM Release Status Mar 12, 2024
llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Mar 13, 2024
@fhahn @tstellar
[DSE] Remove malloc from EarliestEscapeInfo before removing. (llvm#84157
39e3ba8 
)

Not removing the malloc from earliest escape info leaves stale entries
in the cache.

Fixes llvm#84051.

PR: llvm#84157
(cherry picked from commit eb8f379)
freebsd-git pushed a commit to freebsd/freebsd-src that referenced this issue Apr 5, 2024
@DimitryAndric
Merge commit eb8f379567e8 from llvm-project (by Florian Hahn):
aaabed1 
  [DSE] Remove malloc from EarliestEscapeInfo before removing. (#84157)

  Not removing the malloc from earliest escape info leaves stale entries
  in the cache.

  Fixes llvm/llvm-project#84051.

  PR: llvm/llvm-project#84157

This fixes a crash in clang (usually a bus error, but can also be
another memory error) when compiling the science/siconos port.

PR:		278174
Reported by:	yuri
MFC after:	3 days
freebsd-git pushed a commit to freebsd/freebsd-src that referenced this issue Apr 8, 2024
@DimitryAndric
Merge commit eb8f379567e8 from llvm-project (by Florian Hahn):
928ea80 
  [DSE] Remove malloc from EarliestEscapeInfo before removing. (#84157)

  Not removing the malloc from earliest escape info leaves stale entries
  in the cache.

  Fixes llvm/llvm-project#84051.

  PR: llvm/llvm-project#84157

This fixes a crash in clang (usually a bus error, but can also be
another memory error) when compiling the science/siconos port.

PR:		278174
Reported by:	yuri
MFC after:	3 days

(cherry picked from commit aaabed1)
freebsd-git pushed a commit to freebsd/freebsd-src that referenced this issue Apr 8, 2024
@DimitryAndric
Merge commit eb8f379567e8 from llvm-project (by Florian Hahn):
17e3245 
  [DSE] Remove malloc from EarliestEscapeInfo before removing. (#84157)

  Not removing the malloc from earliest escape info leaves stale entries
  in the cache.

  Fixes llvm/llvm-project#84051.

  PR: llvm/llvm-project#84157

This fixes a crash in clang (usually a bus error, but can also be
another memory error) when compiling the science/siconos port.

PR:		278174
Reported by:	yuri
MFC after:	3 days

(cherry picked from commit aaabed1)
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this issue Aug 7, 2024
@DimitryAndric @bsdjhb
Merge commit eb8f379567e8 from llvm-project (by Florian Hahn):
f955804 
  [DSE] Remove malloc from EarliestEscapeInfo before removing. (#84157)

  Not removing the malloc from earliest escape info leaves stale entries
  in the cache.

  Fixes llvm/llvm-project#84051.

  PR: llvm/llvm-project#84157

This fixes a crash in clang (usually a bus error, but can also be
another memory error) when compiling the science/siconos port.

PR:		278174
Reported by:	yuri
MFC after:	3 days
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash-on-valid llvm:transforms release:backport
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 18.X Release
Development

Successfully merging a pull request may close this issue.

[DSE] Remove malloc from EarliestEscapeInfo before removing. fhahn/llvm-project
6 participants
@nikic @fhahn @EugeneZelenko @dtcxzyw @llvmbot @JonPsson1