[Clang] Clang assertion failure when run with `-cc1 -ast-dump` args and a LLVM IR file

[yronglin]

Clang assertion failed at

llvm-project/clang/lib/Frontend/FrontendAction.cpp

Lines 759 to 761 in 599adf3

	if (Input.getKind().getLanguage() == Language::LLVM_IR) {
	assert(hasIRSupport() &&
	"This action does not have IR file support!");

, I think we'de better to add a diagnostic message instead assertion failure?

Assertion failed: (hasIRSupport() && "This action does not have IR file support!"), function BeginSourceFile, file FrontendAction.cpp, line 761.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.

[llvmbot]

@llvm/issue-subscribers-clang-driver

Author: None (yronglin)

Clang assertion failed at https://github.com/llvm/llvm-project/blob/599adf30afe5802fab80419ec5bb896036a1c8fb/clang/lib/Frontend/FrontendAction.cpp#L759-L761 , I think we'de better to add a diagnostic message instead assertion failure? ``` Assertion failed: (hasIRSupport() && "This action does not have IR file support!"), function BeginSourceFile, file FrontendAction.cpp, line 761. PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script. ```

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: None (yronglin)

Clang assertion failed at https://github.com/llvm/llvm-project/blob/599adf30afe5802fab80419ec5bb896036a1c8fb/clang/lib/Frontend/FrontendAction.cpp#L759-L761 , I think we'de better to add a diagnostic message instead assertion failure? ``` Assertion failed: (hasIRSupport() && "This action does not have IR file support!"), function BeginSourceFile, file FrontendAction.cpp, line 761. PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script. ```

[shafik]

It does seem like this could be a diagnostic as opposed to a assertion, it was landed a long time ago: 9507f9c

[yronglin]

It does seem like this could be a diagnostic as opposed to a assertion, it was landed a long time ago: 9507f9c

Thanks for confirmation! I've a submitted PR to add a diagnostic.