Skip to content

4 * declaration and definition mismatch. #88716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dcb314 opened this issue Apr 15, 2024 · 2 comments
Closed

4 * declaration and definition mismatch. #88716

dcb314 opened this issue Apr 15, 2024 · 2 comments
Assignees

Comments

@dcb314
Copy link

dcb314 commented Apr 15, 2024

Static analyser cppcheck says

clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1302:45: warning: Function 'invalidateRegions' argument order different: declaration 'store, Values, E, Count, LCtx, Call, IS, ITraits, Invalidated, InvalidatedTopLevel' definition 'store, Values, Ex, Count, LCtx, Call, IS, ITraits, TopLevelRegions, Invalidated' [funcArgOrderDifferent]

mlir/lib/Dialect/SparseTensor/Transforms/Utils/SparseTensorIterator.cpp:1336:49: warning: Function 'makeSparseTensorLevel' argument order different: declaration 'builder, loc, t, tid, l' definition 'b, l, t, tid, lvl' [funcArgOrderDifferent]

llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:3155:54: warning: Function 'matchSelectFromAndOr' argument order different: declaration 'A, B, C, D, InvertFalseVal' definition 'A, C, B, D, InvertFalseVal' [funcArgOrderDifferent]

llvm/lib/Transforms/Vectorize/VPlan.cpp:998:48: warning: Function 'updateDominatorTree' argument order different: declaration 'DT, LoopLatchBB, LoopPreHeaderBB, LoopExitBB' definition 'DT, LoopHeaderBB, LoopLatchBB, LoopExitBB' [funcArgOrderDifferent]

Suggest code rework.

@Troy-Butler
Copy link
Contributor

Hi, could this please be assigned to me?

NagyDonat pushed a commit that referenced this issue Apr 26, 2024
#89512)

Addresses issue #88716.

Some function parameter names in the affected header files did not match
the parameter names in the definitions, or were listed in a different
order.

---------

Signed-off-by: Troy-Butler <[email protected]>
@RKSimon
Copy link
Collaborator

RKSimon commented May 4, 2024

@dcb314 @Troy-Butler OK to close now?

@RKSimon RKSimon closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants