lld-link can not resolve relative path for MSVC linker LIBPATH:

[lygstate]

[build] C:\WINDOWS\system32\cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E vs_link_dll --intdir=src\YY-Thunks.UnitTest\CMakeFiles\api-ms-win-core-fibers.UnitTest.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100261~1.0\x86\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100261~1.0\x86\mt.exe --manifests  -- C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\Llvm\bin\lld-link.exe /nologo src\Thunks\CMakeFiles\win-polyfill-override-dll.dir\win-polyfill-override.cpp.obj src\YY-Thunks.UnitTest\CMakeFiles\api-ms-win-core-fibers.UnitTest.dir\api-ms-win-core-fibers.UnitTest.cpp.obj  /out:bin\api-ms-win-core-fibers.UnitTest.dll /implib:lib\api-ms-win-core-fibers.UnitTest.lib /pdb:bin\api-ms-win-core-fibers.UnitTest.pdb /dll /version:0.0 /machine:X86 /debug /INCREMENTAL -LIBPATH:C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\AUXILI~1\VS\UnitTest\lib lib\win-polyfill-static.lib && cd ."
[build] LINK Pass 1: command "C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\Llvm\bin\lld-link.exe /nologo src\Thunks\CMakeFiles\win-polyfill-override-dll.dir\win-polyfill-override.cpp.obj src\YY-Thunks.UnitTest\CMakeFiles\api-ms-win-core-fibers.UnitTest.dir\api-ms-win-core-fibers.UnitTest.cpp.obj /out:bin\api-ms-win-core-fibers.UnitTest.dll /implib:lib\api-ms-win-core-fibers.UnitTest.lib /pdb:bin\api-ms-win-core-fibers.UnitTest.pdb /dll /version:0.0 /machine:X86 /debug /INCREMENTAL -LIBPATH:C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\AUXILI~1\VS\UnitTest\lib lib\win-polyfill-static.lib /MANIFEST /MANIFESTFILE:src\YY-Thunks.UnitTest\CMakeFiles\api-ms-win-core-fibers.UnitTest.dir/intermediate.manifest src\YY-Thunks.UnitTest\CMakeFiles\api-ms-win-core-fibers.UnitTest.dir/manifest.res" failed (exit code 1) with the following output:
[build] lld-link: error: could not open 'x86\Microsoft.VisualStudio.TestTools.CppUnitTestFramework.lib': no such file or directory

The LIBPATH:C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\AUXILI~1\VS\UnitTest\lib
The lib  'x86\Microsoft.VisualStudio.TestTools.CppUnitTestFramework.lib':
And the absolute path of lib is C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\AUXILI~1\VS\UnitTest\lib\x86\Microsoft.VisualStudio.TestTools.CppUnitTestFramework.lib

[llvmbot]

@llvm/issue-subscribers-lld-coff

Author: Yonggang Luo (lygstate)

[build] C:\WINDOWS\system32\cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E vs_link_dll --intdir=src\YY-Thunks.UnitTest\CMakeFiles\api-ms-win-core-fibers.UnitTest.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100261~1.0\x86\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100261~1.0\x86\mt.exe --manifests -- C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\Llvm\bin\lld-link.exe /nologo src\Thunks\CMakeFiles\win-polyfill-override-dll.dir\win-polyfill-override.cpp.obj src\YY-Thunks.UnitTest\CMakeFiles\api-ms-win-core-fibers.UnitTest.dir\api-ms-win-core-fibers.UnitTest.cpp.obj /out:bin\api-ms-win-core-fibers.UnitTest.dll /implib:lib\api-ms-win-core-fibers.UnitTest.lib /pdb:bin\api-ms-win-core-fibers.UnitTest.pdb /dll /version:0.0 /machine:X86 /debug /INCREMENTAL -LIBPATH:C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\AUXILI~1\VS\UnitTest\lib lib\win-polyfill-static.lib && cd ." [build] LINK Pass 1: command "C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\Llvm\bin\lld-link.exe /nologo src\Thunks\CMakeFiles\win-polyfill-override-dll.dir\win-polyfill-override.cpp.obj src\YY-Thunks.UnitTest\CMakeFiles\api-ms-win-core-fibers.UnitTest.dir\api-ms-win-core-fibers.UnitTest.cpp.obj /out:bin\api-ms-win-core-fibers.UnitTest.dll /implib:lib\api-ms-win-core-fibers.UnitTest.lib /pdb:bin\api-ms-win-core-fibers.UnitTest.pdb /dll /version:0.0 /machine:X86 /debug /INCREMENTAL -LIBPATH:C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\AUXILI~1\VS\UnitTest\lib lib\win-polyfill-static.lib /MANIFEST /MANIFESTFILE:src\YY-Thunks.UnitTest\CMakeFiles\api-ms-win-core-fibers.UnitTest.dir/intermediate.manifest src\YY-Thunks.UnitTest\CMakeFiles\api-ms-win-core-fibers.UnitTest.dir/manifest.res" failed (exit code 1) with the following output: [build] lld-link: error: could not open 'x86\Microsoft.VisualStudio.TestTools.CppUnitTestFramework.lib': no such file or directory

The LIBPATH:C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\AUXILI~1\VS\UnitTest\lib
The lib  'x86\Microsoft.VisualStudio.TestTools.CppUnitTestFramework.lib':
And the absolute path of lib is C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\AUXILI~1\VS\UnitTest\lib\x86\Microsoft.VisualStudio.TestTools.CppUnitTestFramework.lib

[compnerd]

This feels like the same issue that @aganea and @glandium were discussing wrt #76304 - the short path (PROGRA~1) is getting resolved and then lld is being passed a path containing a space which breaks the argument parsing.

[aganea]

Looks like it. @lygstate could you please provide more info on the reproducer that leads to this issue?

[aganea]

This feels like the same issue that @aganea and @glandium were discussing wrt #76304 - the short path (PROGRA~1) is getting resolved and then lld is being passed a path containing a space which breaks the argument parsing.

Although the output above shows that it's using the LLVM package which is part of Visual Studio C:\PROGRA1\MICROS2\2022\COMMUN1\VC\Tools\Llvm\bin\lld-link.exe which is on LLVM 17.0.3 (does not include #76304).

[lygstate]

This feels like the same issue that @aganea and @glandium were discussing wrt #76304 - the short path (PROGRA~1) is getting resolved and then lld is being passed a path containing a space which breaks the argument parsing.

Although the output above shows that it's using the LLVM package which is part of Visual Studio C:\PROGRA1\MICROS2\2022\COMMUN1\VC\Tools\Llvm\bin\lld-link.exe which is on LLVM 17.0.3 (does not include #76304).

It's LLVM16, oh maybe I can try LLVM 18 first

[lygstate]

Yeah, LLVM 17 works