Skip to content

Implement the WorldRayOrigin HLSL Function #99187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
12 tasks
Tracked by #99235
farzonl opened this issue Jul 16, 2024 · 0 comments
Open
12 tasks
Tracked by #99235

Implement the WorldRayOrigin HLSL Function #99187

farzonl opened this issue Jul 16, 2024 · 0 comments
Labels
backend:DirectX backend:SPIR-V bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues.

Comments

@farzonl
Copy link
Member

farzonl commented Jul 16, 2024

  • Implement WorldRayOrigin clang builtin,
  • Link WorldRayOrigin clang builtin with hlsl_intrinsics.h
  • Add sema checks for WorldRayOrigin to CheckHLSLBuiltinFunctionCall in SemaChecking.cpp
  • Add codegen for WorldRayOrigin to EmitHLSLBuiltinExpr in CGBuiltin.cpp
  • Add codegen tests to clang/test/CodeGenHLSL/builtins/WorldRayOrigin.hlsl
  • Add sema tests to clang/test/SemaHLSL/BuiltIns/WorldRayOrigin-errors.hlsl
  • Create the int_dx_WorldRayOrigin intrinsic in IntrinsicsDirectX.td
  • Create the DXILOpMapping of int_dx_WorldRayOrigin to 147 in DXIL.td
  • Create the WorldRayOrigin.ll and WorldRayOrigin_errors.ll tests in llvm/test/CodeGen/DirectX/
  • Create the int_spv_WorldRayOrigin intrinsic in IntrinsicsSPIRV.td
  • In SPIRVInstructionSelector.cpp create the WorldRayOrigin lowering and map it to int_spv_WorldRayOrigin in SPIRVInstructionSelector::selectIntrinsic.
  • Create SPIR-V backend test case in llvm/test/CodeGen/SPIRV/hlsl-intrinsics/WorldRayOrigin.ll

DirectX

DXIL Opcode DXIL OpName Shader Model Shader Stages
147 WorldRayOrigin 6.3 ('library', 'intersection', 'anyhit', 'closesthit', 'miss')

SPIR-V

WorldRayOriginKHR

Short Description

WorldRayOriginKHR - Ray origin in world space

Description

WorldRayOriginKHR
A variable decorated with the WorldRayOriginKHR decoration will
specify the origin of the ray being processed, in world space. The value
is the parameter passed into the pipeline trace ray instruction.

Valid Usage


  • VUID-WorldRayOriginKHR-WorldRayOriginKHR-04431

    The WorldRayOriginKHR decoration must be used only within the
    IntersectionKHR , AnyHitKHR , ClosestHitKHR , or
    MissKHR Execution Model


  • VUID-WorldRayOriginKHR-WorldRayOriginKHR-04432

    The variable decorated with WorldRayOriginKHR must be declared
    using the Input Storage Class


  • VUID-WorldRayOriginKHR-WorldRayOriginKHR-04433

    The variable decorated with WorldRayOriginKHR must be declared
    as a three-component vector of 32-bit floating-point values

Test Case(s)

Example 1

//dxc WorldRayOrigin_test.hlsl -T lib_6_8 -enable-16bit-types -O0

export float3 fn() {
    return WorldRayOrigin();
}

SPIRV Example(s):

Example 2

//dxc WorldRayOrigin_spirv_test.hlsl -T lib_6_8 -E fn -enable-16bit-types -spirv -fspv-target-env=universal1.5 -fcgl -O0

[shader("intersection")]
void fn() {
float3 	ret = WorldRayOrigin();
}

HLSL:

The world-space origin of the current ray.

Syntax

float3 WorldRayOrigin();

Remarks

This function can be called from the following raytracing shader types:

See also

Direct3D 12 Raytracing HLSL Reference

@farzonl farzonl added backend:DirectX backend:SPIR-V bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues. labels Jul 16, 2024
@damyanp damyanp moved this to Ready in HLSL Support Oct 30, 2024
@damyanp damyanp moved this from Ready to Planning in HLSL Support Oct 30, 2024
@damyanp damyanp moved this from Planning to Designing in HLSL Support Nov 26, 2024
@damyanp damyanp removed the status in HLSL Support Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:DirectX backend:SPIR-V bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues.
Projects
Status: No status
Development

No branches or pull requests

1 participant