Skip to content

Implement the IsHelperLane HLSL Function #99233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
12 tasks
Tracked by #99235
farzonl opened this issue Jul 16, 2024 · 1 comment
Open
12 tasks
Tracked by #99235

Implement the IsHelperLane HLSL Function #99233

farzonl opened this issue Jul 16, 2024 · 1 comment
Labels
backend:DirectX backend:SPIR-V bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues.

Comments

@farzonl
Copy link
Member

farzonl commented Jul 16, 2024

  • Implement IsHelperLane clang builtin,
  • Link IsHelperLane clang builtin with hlsl_intrinsics.h
  • Add sema checks for IsHelperLane to CheckHLSLBuiltinFunctionCall in SemaChecking.cpp
  • Add codegen for IsHelperLane to EmitHLSLBuiltinExpr in CGBuiltin.cpp
  • Add codegen tests to clang/test/CodeGenHLSL/builtins/IsHelperLane.hlsl
  • Add sema tests to clang/test/SemaHLSL/BuiltIns/IsHelperLane-errors.hlsl
  • Create the int_dx_IsHelperLane intrinsic in IntrinsicsDirectX.td
  • Create the DXILOpMapping of int_dx_IsHelperLane to 221 in DXIL.td
  • Create the IsHelperLane.ll and IsHelperLane_errors.ll tests in llvm/test/CodeGen/DirectX/
  • Create the int_spv_IsHelperLane intrinsic in IntrinsicsSPIRV.td
  • In SPIRVInstructionSelector.cpp create the IsHelperLane lowering and map it to int_spv_IsHelperLane in SPIRVInstructionSelector::selectIntrinsic.
  • Create SPIR-V backend test case in llvm/test/CodeGen/SPIRV/hlsl-intrinsics/IsHelperLane.ll

DirectX

DXIL Opcode DXIL OpName Shader Model Shader Stages
221 IsHelperLane 6.6 ()

SPIR-V

OpIsHelperInvocationEXT:

Description:

Reserved.

Capability:
DemoteToHelperInvocationEXT

Reserved.

Word Count Opcode Results Operands

3

5381

<id>
Result Type

Result <id>

Test Case(s)

Example 1

//dxc IsHelperLane_test.hlsl -T lib_6_8 -enable-16bit-types -O0

export bool fn() {
    return IsHelperLane();
}

HLSL:

Syntax

bool IsHelperLane();

Type Description

Name Template Type Component Type Size
ret scalar bool 1

Minimum Shader Model

This function is supported in the following shader models.

Shader Model Supported
Shader Model 6.6 and higher shader models yes

Shader Stages

See also

@farzonl farzonl added backend:DirectX backend:SPIR-V bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues. labels Jul 16, 2024
@damyanp damyanp moved this to Ready in HLSL Support Oct 30, 2024
@damyanp damyanp moved this from Ready to Planning in HLSL Support Oct 30, 2024
@damyanp damyanp moved this from Planning to Designing in HLSL Support Jan 21, 2025
@damyanp
Copy link
Contributor

damyanp commented Jan 21, 2025

@farzonl - this HLSL function was backported to older shader models where there wasn't necessarily a dxil op for it. The issue here needs to be updated to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:DirectX backend:SPIR-V bot:HLSL HLSL HLSL Language Support metabug Issue to collect references to a group of similar or related issues.
Projects
Status: No status
Development

No branches or pull requests

2 participants