[CodeGen] TwoAddressInstructionPass: Control NumVisited limit via command line option #100125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AZero13
changed the title
|
@RKSimon Is this good? |
topperc
reviewed
Jul 23, 2024
| // Limit the number of rescheduling visits to dependent instructions. | ||
| // FIXME: Arbitrary limit to reduce compile time cost. | ||
| static cl::opt<unsigned> | ||
| MaxVisits("twoaddr-visit-limit", cl::Hidden, cl::init(10), |
There was a problem hiding this comment.
Should we include "reschedule" in the option name? "twoaddr-reschedule-visit-limit"?
There was a problem hiding this comment.
I feel like I am not the person who should make that decision
There was a problem hiding this comment.
twoaddr-reschedule-visit-limit sgtm
AZero13
force-pushed
the
cmd
branch
3 times, most recently
from
38b4afb to
de65a1f
Compare
RKSimon
requested changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of comment made on #80627 - to simplify further investigation into visit limits.