[llvm-config] Add new flag --quote-paths to optionally quote and escape paths
#103397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any of the printed paths by llvm-config contains quotes, spaces, backslashes or dollar sign characters, these paths can be quoted if using --quote-paths and the corresponding characters will be escaped. Following discussion in llvm#76304 Fixes llvm#28117
compnerd
reviewed
Aug 13, 2024
Comment on lines
512
to
518
| bool QuotePaths = false; | ||
| for (int i = 1; i != argc; ++i) { | ||
| if (StringRef(argv[i]) == "--quote-paths") { | ||
| QuotePaths = true; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Could we do something like:
Suggested change
| bool QuotePaths = false; | |
| for (int i = 1; i != argc; ++i) { | |
| if (StringRef(argv[i]) == "--quote-paths") { | |
| QuotePaths = true; | |
| break; | |
| } | |
| } | |
| bool QuotePaths = std::any_of(&argv[0], &argv[argc], [](const char *arg) { | |
| return StringRef(arg) == "--quote-paths"; | |
| }); |
tru
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any of the printed paths by llvm-config contain quotes, spaces, backslashes or dollar sign characters, these paths will be quoted and escaped, but only if using
--quote-paths. The previous behavior is retained for compatibility and--quote-pathsis there to acknowledge the migration to the new behavior.Following discussion in #76304
Fixes #28117
Superseeds #97305
I could also do what @tothambrus11 suggests in #97305 (comment) but that makes all Windows paths quoted & escaped since they all contain backslashes.