Skip to content

[MachineOutliner][NFC] Remove unnecessary RepeatedSequenceLocs.clear() #106171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[MachineOutliner][NFC] Remove unnecessary RepeatedSequenceLocs.clear() #106171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions llvm/lib/Target/AArch64/AArch64InstrInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8990,7 +8990,7 @@ AArch64InstrInfo::getOutliningCandidateInfo(
NumBytesNoStackCalls <= RepeatedSequenceLocs.size() * 12) {
RepeatedSequenceLocs = CandidatesWithoutStackFixups;
FrameID = MachineOutlinerNoLRSave;
if (RepeatedSequenceLocs.size() < 2)
if (RepeatedSequenceLocs.size() < MinRepeats)
return std::nullopt;
} else {
SetCandidateCallInfo(MachineOutlinerDefault, 12);
Expand Down Expand Up @@ -9051,10 +9051,8 @@ AArch64InstrInfo::getOutliningCandidateInfo(
}

// If we dropped all of the candidates, bail out here.
if (RepeatedSequenceLocs.size() < MinRepeats) {
RepeatedSequenceLocs.clear();
if (RepeatedSequenceLocs.size() < MinRepeats)
return std::nullopt;
}
}

// Does every candidate's MBB contain a call? If so, then we might have a call
Expand All @@ -9079,10 +9077,8 @@ AArch64InstrInfo::getOutliningCandidateInfo(

if (ModStackToSaveLR) {
// We can't fix up the stack. Bail out.
if (!AllStackInstrsSafe) {
RepeatedSequenceLocs.clear();
if (!AllStackInstrsSafe)
return std::nullopt;
}

// Save + restore LR.
NumBytesToCreateFrame += 8;
Expand Down
Loading