[TableGen] Add explicit symbol visibility macros to code generated #107873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsfod
changed the title
Update llvm's TableGen to add explicit symbol visibility macros to function declarations it creates The symbols need to be export from llvm's shared library for Clang and some OpenMP tests
fsfod
force-pushed
the
exported-api/tablegen
branch
from
47466b4 to
f602bb4
Compare
|
I've rebased and fixed the conflict |
|
Is this patch NFC since we aren't yet compiling with -fvisibility=hidden? |
|
I would think so, but an in an offline chat with @compnerd he wondered why do we need to export this instead of clang and tests getting there own copy of the functions. |
tmsri
pushed a commit
to tmsri/llvm-project
that referenced
this pull request
Sep 19, 2024
…lvm#107873) Update llvm's TableGen to emit new explicit symbol visibility macros I added in llvm#96630 to the function declarations it creates The generated functions need to be exported from llvm's shared library for Clang and some OpenMP tests. @compnerd
Open
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update llvm's TableGen to emit new explicit symbol visibility macros I added in #96630 to the function declarations it creates
The generated functions need to be exported from llvm's shared library for Clang and some OpenMP tests. @compnerd