Skip to content

[MC] Explicitly mark MCSymbol for MO_ExternalSymbol #108880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 20, 2024
Merged

[MC] Explicitly mark MCSymbol for MO_ExternalSymbol #108880

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8bf3c85
Explicitly mark MCSymbol for MO_ExternalSymbol
weiweichen Sep 16, 2024
ac9dc49
Merge branch 'main' of https://github.com/llvm/llvm-project into weiw…
weiweichen Sep 17, 2024
f353d11
Fix load-hidden.ll
weiweichen Sep 17, 2024
007394c
Merge branch 'main' of https://github.com/llvm/llvm-project into weiw…
weiweichen Sep 17, 2024
4ac1150
Merge branch 'main' of https://github.com/llvm/llvm-project into weiw…
weiweichen Sep 17, 2024
0c5f976
Fix silly goof because I cannot read switch code.
weiweichen Sep 18, 2024
9fb68be
Merge branch 'main' of https://github.com/llvm/llvm-project into weiw…
weiweichen Sep 18, 2024
741c735
Revert test change in load-hidden.ll.
weiweichen Sep 18, 2024
afd0dea
Merge branch 'main' of https://github.com/llvm/llvm-project into weiw…
weiweichen Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion llvm/lib/Target/X86/X86MCInstLower.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,12 @@ MCOperand X86MCInstLower::LowerMachineOperand(const MachineInstr *MI,
return MCOperand::createImm(MO.getImm());
case MachineOperand::MO_MachineBasicBlock:
case MachineOperand::MO_GlobalAddress:
case MachineOperand::MO_ExternalSymbol:
return LowerSymbolOperand(MO, GetSymbolFromOperand(MO));
case MachineOperand::MO_ExternalSymbol: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean for MO_GlobalAddress and MO_MachineBasicBlock to also hit this branch?

Copy link
Contributor Author

@weiweichen weiweichen Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welp, no, 🤦‍♀️, thanks for pointing this out!

MCSymbol *Sym = GetSymbolFromOperand(MO);
Sym->setExternal(true);
return LowerSymbolOperand(MO, Sym);
}
case MachineOperand::MO_MCSymbol:
return LowerSymbolOperand(MO, MO.getMCSymbol());
case MachineOperand::MO_JumpTableIndex:
Expand Down
Loading