[libc++] Add _LIBCPP_NO_CFI to __allocate_unique_temporary_buffer

[frederick-vs-ja]

Follows up #100914. Addresses the issue revealed in #100914 (comment).

[llvmbot]

@llvm/pr-subscribers-libcxx

Author: A. Jiang (frederick-vs-ja)

Changes

Follows up #100914. Addresses the issue revealed in #100914 (comment).

---

Full diff: https://github.com/llvm/llvm-project/pull/109682.diff

1 Files Affected:

• (modified) libcxx/include/__memory/unique_temporary_buffer.h (+1-1)

diff --git a/libcxx/include/__memory/unique_temporary_buffer.h b/libcxx/include/__memory/unique_temporary_buffer.h
index b9e2a47332682f..001254e8fa4be1 100644
--- a/libcxx/include/__memory/unique_temporary_buffer.h
+++ b/libcxx/include/__memory/unique_temporary_buffer.h
@@ -47,7 +47,7 @@ template <class _Tp>
 using __unique_temporary_buffer = unique_ptr<_Tp, __temporary_buffer_deleter<_Tp> >;
 
 template <class _Tp>
-inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX23 __unique_temporary_buffer<_Tp>
+inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_NO_CFI _LIBCPP_CONSTEXPR_SINCE_CXX23 __unique_temporary_buffer<_Tp>
 __allocate_unique_temporary_buffer(ptrdiff_t __count) {
   using __deleter_type       = __temporary_buffer_deleter<_Tp>;
   using __unique_buffer_type = __unique_temporary_buffer<_Tp>;

[nico]

Thanks! LG (but I'm not a code owner here, so you'll need an actual LG too).

Since get_temporary_buffer is going away anyways, it's probably not worth removing the _LIBCPP_NO_CFI there.

[ldionne]

Would it make sense to add a CFI-sanitized CI job?