[HLSL] Implement WaveReadLaneAt intrinsics
#110739
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inbelic
force-pushed
the
inbelic/wave-read-lane-at
branch
from
fdf04ec to
cb3467d
Compare
- create a clang built-in
- add mapping to dxil opcode
- add lowering to SPIR-V GroupNonUniformShuffle with Scope = 2
(Group)
- add sema checks
- add related tests
inbelic
force-pushed
the
inbelic/wave-read-lane-at
branch
from
cb3467d to
0320a5a
Compare
inbelic
commented
Oct 1, 2024
|
|
||
| // Check if the operation supports overload types and OverloadTy is valid | ||
| // per the specified types for the operation | ||
| if ((ValidTyMask != OverloadKind::UNDEFINED) && | ||
| (ValidTyMask & (uint16_t)Kind) == 0) | ||
| (ValidTyMask & (uint16_t)Kind) == 0) { | ||
| OverloadTy->print(llvm::errs()); |
There was a problem hiding this comment.
Whoops, will remove when I address other comments
You can test this locally with the following command:git-clang-format --diff f3c408d1726f6a921212faf68085f68bf8533f0c 0320a5acec2565608cb91b271f6cda49fc364bb7 --extensions cpp,h -- clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGHLSLRuntime.h clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/lib/Sema/SemaHLSL.cpp llvm/lib/Target/DirectX/DXILOpBuilder.cpp llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp llvm/utils/TableGen/DXILEmitter.cppView the diff from clang-format here.diff --git a/clang/lib/Headers/hlsl/hlsl_intrinsics.h b/clang/lib/Headers/hlsl/hlsl_intrinsics.h
index f3707d8076..a7bdc353ae 100644
--- a/clang/lib/Headers/hlsl/hlsl_intrinsics.h
+++ b/clang/lib/Headers/hlsl/hlsl_intrinsics.h
@@ -2020,7 +2020,7 @@ __attribute__((convergent)) bool WaveIsFirstLane();
template <typename T>
_HLSL_AVAILABILITY(shadermodel, 6.0)
_HLSL_BUILTIN_ALIAS(__builtin_hlsl_wave_read_lane_at)
-__attribute__((convergent)) T WaveReadLaneAt(T, int32_t);
+ __attribute__((convergent)) T WaveReadLaneAt(T, int32_t);
//===----------------------------------------------------------------------===//
// sign builtins
|
inbelic
commented
Oct 1, 2024
| .addUse(GR.getSPIRVTypeID(ResType)) | ||
| .addUse(I.getOperand(2).getReg()) | ||
| .addUse(I.getOperand(3).getReg()) | ||
| .addUse(GR.getOrCreateConstInt(2, I, IntTy, TII)); |
There was a problem hiding this comment.
IIUC, an HLSL wave corresponds to the SPIR-V workgroup scope, which is denoted as 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.