Skip to content

[LLD][ELF] Assert TargetInfo correctness for when ctx becomes a local #111139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[LLD][ELF] Assert TargetInfo correctness for when ctx becomes a local #111139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lld/ELF/Driver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3123,6 +3123,10 @@ template <class ELFT> void LinkerDriver::link(opt::InputArgList &args) {
// relocations or writing a PLT section. It also contains target-dependent
// values such as a default image base address.
ctx.target = getTarget(ctx);
// Currently, the TargetInfo structures in are function-statics. Guard against
// that causing problems if ctx is changed from a global variable to a local
// variable.
assert(&ctx.target->ctx == &ctx);

ctx.arg.eflags = ctx.target->calcEFlags();
// maxPageSize (sometimes called abi page size) is the maximum page size that
Expand Down
Loading