Skip to content

[SPIR-V] Add missing ScalarOpts library #114384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

svenvh
Copy link
Member

@svenvh svenvh commented Oct 31, 2024

Fixes an "undefined reference to `llvm::createRegToMemWrapperPass()'" linker error introduced by cba7055 ("[SPIR-V] Fix BB ordering & register lifetime (#111026)", 2024-10-30).

Fixes an "undefined reference to `llvm::createRegToMemWrapperPass()'"
linker error introduced by cba7055 ("[SPIR-V] Fix BB ordering &
register lifetime (llvm#111026)", 2024-10-30).
@llvmbot
Copy link
Member

llvmbot commented Oct 31, 2024

@llvm/pr-subscribers-backend-spir-v

Author: Sven van Haastregt (svenvh)

Changes

Fixes an "undefined reference to `llvm::createRegToMemWrapperPass()'" linker error introduced by cba7055 ("[SPIR-V] Fix BB ordering & register lifetime (#111026)", 2024-10-30).


Full diff: https://github.com/llvm/llvm-project/pull/114384.diff

1 Files Affected:

  • (modified) llvm/lib/Target/SPIRV/CMakeLists.txt (+1)
diff --git a/llvm/lib/Target/SPIRV/CMakeLists.txt b/llvm/lib/Target/SPIRV/CMakeLists.txt
index 326343ae278148..aa83d997578fd5 100644
--- a/llvm/lib/Target/SPIRV/CMakeLists.txt
+++ b/llvm/lib/Target/SPIRV/CMakeLists.txt
@@ -56,6 +56,7 @@ add_llvm_target(SPIRVCodeGen
   MC
   SPIRVDesc
   SPIRVInfo
+  ScalarOpts
   SelectionDAG
   Support
   Target

Copy link
Contributor

@VyacheslavLevytskyy VyacheslavLevytskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I was digging in the same problem right now.

@svenvh svenvh merged commit 22081dc into llvm:main Oct 31, 2024
9 of 11 checks passed
@svenvh svenvh deleted the spirv-scalaropts branch October 31, 2024 10:50
@Keenuts
Copy link
Contributor

Keenuts commented Oct 31, 2024

Oh thanks for the fix!

smallp-o-p pushed a commit to smallp-o-p/llvm-project that referenced this pull request Nov 3, 2024
Fixes an "undefined reference to `llvm::createRegToMemWrapperPass()'"
linker error introduced by cba7055 ("[SPIR-V] Fix BB ordering &
register lifetime (llvm#111026)", 2024-10-30).
NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request Nov 4, 2024
Fixes an "undefined reference to `llvm::createRegToMemWrapperPass()'"
linker error introduced by cba7055 ("[SPIR-V] Fix BB ordering &
register lifetime (llvm#111026)", 2024-10-30).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants