Backtrace support for flang #118179
Merged
Backtrace support for flang #118179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…delete std::exit in PrintBacktrace
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
tblah
reviewed
Dec 2, 2024
flang/CMakeLists.txt
Outdated
Comment on lines
93
to
97
| # function checks | ||
| find_package(Backtrace) | ||
| set(HAVE_BACKTRACE ${Backtrace_FOUND}) | ||
| set(BACKTRACE_HEADER ${Backtrace_HEADER}) | ||
|
|
There was a problem hiding this comment.
Please could you try putting this in flang/runtime/CMakeLists.txt
tblah
reviewed
Dec 2, 2024
flang/include/flang/Runtime/stop.h
Outdated
| @@ -29,6 +29,7 @@ NORETURN void RTNAME(ProgramEndStatement)(NO_ARGUMENTS); | |||
| // Extensions | |||
| NORETURN void RTNAME(Exit)(int status DEFAULT_VALUE(EXIT_SUCCESS)); | |||
| NORETURN void RTNAME(Abort)(NO_ARGUMENTS); | |||
| void RTNAME(Backtrace)(NO_ARGUMENTS); | |||
There was a problem hiding this comment.
@jeanPerier pointed out we don't need any of the changes in flang/lib in this case: pointing you at fdate
Suggested change
| void RTNAME(Backtrace)(NO_ARGUMENTS); | |
| void FORTRAN_PROCEDURE_NAME(Backtrace)(NO_ARGUMENTS); |
With this you shouldn't need any of the frontend changes (flang/lib, and associated header changes).
tblah
approved these changes
Dec 9, 2024
jeanPerier
reviewed
Dec 9, 2024
| [[noreturn]] void RTNAME(Abort)() { | ||
| // TODO: Add backtrace call, unless with `-fno-backtrace`. | ||
| PrintBacktrace(); |
There was a problem hiding this comment.
Could you make that one also conditional on #ifdef HAVE_BACKTRACE I do not think ABORT should crash with "Handle the case when a backtrace is not available\n" on platforms that have no backtrace.
It could lead people to believe that the abort is related to BACKTRACE while it is not.
There was a problem hiding this comment.
You are right, thanks for pointing this out.
Thank you for your corrections to my questions. I am very grateful. If you think there is no problem, you can merge it. |
|
It looks like the runtime should link against libexecinfo on *BSD's. Backtrace_LIBRARY is filed in. I am not sure of how to go about linking with the runtime in runtime/CMakeLists.txt |
|
Hi @brad0, thanks for looking into this. I don't have a BSD machine to test but I would guess something like the following would work in You can find CMake's documentation here (e.g. for |
|
@tblah Ok, let me play around with that and see what I can come up with. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed build failures in old PRs due to missing files