[CFIFixup] Factor logic into helpers and use range-based loops (NFC) #125137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`runOnMachineFunction` is getting long (>100 lines), and the logic for computing block info and performing block fixup can be abstracted away. Reduce nesting in the main block fixup loop and name conditions to reflect their purpose. Replace manual usage of iterators with a range-based for loop. Source: - https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code - https://llvm.org/docs/CodingStandards.html#use-range-based-for-loops-wherever-possible - https://llvm.org/docs/CodingStandards.html#don-t-evaluate-end-every-time-through-a-loop
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/163/builds/12726 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/17106 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/12855 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/133/builds/10660 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/7482 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/180/builds/12313 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/160/builds/12316 Here is the relevant piece of the build log for the reference |
dhoekwater
added a commit
that referenced
this pull request
Jan 31, 2025
…s (NFC) (#125137)" This reverts commit f14f197, which breaks a number of build bots: - https://lab.llvm.org/buildbot/#/builders/163/builds/12726 - https://lab.llvm.org/buildbot/#/builders/144/builds/17106 - https://lab.llvm.org/buildbot/#/builders/123/builds/12855 - https://lab.llvm.org/buildbot/#/builders/133/builds/10660 - https://lab.llvm.org/buildbot/#/builders/88/builds/7482 - https://lab.llvm.org/buildbot/#/builders/180/builds/12313 - https://lab.llvm.org/buildbot/#/builders/160/builds/12316
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/16/builds/13067 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/33/builds/10648 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/17666 Here is the relevant piece of the build log for the reference |
dhoekwater
added a commit
that referenced
this pull request
Jan 31, 2025
…s (NFC) #125137" This patch was breaking tests due to inconsistent use of SmallVector. After consolidating SmallVector usages, everything should work as intended.
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/18540 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/92/builds/12982 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runOnMachineFunctionis getting long (>100 lines), and the logicfor computing block info and performing block fixup can be abstracted
away.
Reduce nesting in the main block fixup loop and name conditions to
reflect their purpose.
Replace manual usage of iterators with a range-based for loop.
Source: