Skip to content

[test] Remove -emit-llvm from the and-errors.hlsl test to avoid writing to a potentially write-protected directory #128047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

Icohedron
Copy link
Contributor

@mikaelholmen mentioned that the -emit-llvm argument isn't necessary for the and-errors.hlsl test and may cause issues due to writing to the current (potentially write-protected) directory.

This PR removes the -emit-llvm argument from clang in the RUN lines of the test.

@llvmbot llvmbot added clang Clang issues not falling into any other category HLSL HLSL Language Support labels Feb 20, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 20, 2025

@llvm/pr-subscribers-hlsl

Author: Deric Cheung (Icohedron)

Changes

@mikaelholmen mentioned that the -emit-llvm argument isn't necessary for the and-errors.hlsl test and may cause issues due to writing to the current (potentially write-protected) directory.

This PR removes the -emit-llvm argument from clang in the RUN lines of the test.


Full diff: https://github.com/llvm/llvm-project/pull/128047.diff

1 Files Affected:

  • (modified) clang/test/SemaHLSL/BuiltIns/and-errors.hlsl (+1-2)
diff --git a/clang/test/SemaHLSL/BuiltIns/and-errors.hlsl b/clang/test/SemaHLSL/BuiltIns/and-errors.hlsl
index 0a99feb023d73..d9721140b9bf9 100644
--- a/clang/test/SemaHLSL/BuiltIns/and-errors.hlsl
+++ b/clang/test/SemaHLSL/BuiltIns/and-errors.hlsl
@@ -1,6 +1,5 @@
 // RUN: %clang_cc1 -finclude-default-header -triple \
-// RUN:   dxil-pc-shadermodel6.3-library %s \
-// RUN:   -emit-llvm -O1 -verify
+// RUN:   dxil-pc-shadermodel6.3-library %s -O1 -verify
 
 bool test_too_few_arg(bool a) {
   return __builtin_hlsl_and(a);

@llvmbot
Copy link
Member

llvmbot commented Feb 20, 2025

@llvm/pr-subscribers-clang

Author: Deric Cheung (Icohedron)

Changes

@mikaelholmen mentioned that the -emit-llvm argument isn't necessary for the and-errors.hlsl test and may cause issues due to writing to the current (potentially write-protected) directory.

This PR removes the -emit-llvm argument from clang in the RUN lines of the test.


Full diff: https://github.com/llvm/llvm-project/pull/128047.diff

1 Files Affected:

  • (modified) clang/test/SemaHLSL/BuiltIns/and-errors.hlsl (+1-2)
diff --git a/clang/test/SemaHLSL/BuiltIns/and-errors.hlsl b/clang/test/SemaHLSL/BuiltIns/and-errors.hlsl
index 0a99feb023d73..d9721140b9bf9 100644
--- a/clang/test/SemaHLSL/BuiltIns/and-errors.hlsl
+++ b/clang/test/SemaHLSL/BuiltIns/and-errors.hlsl
@@ -1,6 +1,5 @@
 // RUN: %clang_cc1 -finclude-default-header -triple \
-// RUN:   dxil-pc-shadermodel6.3-library %s \
-// RUN:   -emit-llvm -O1 -verify
+// RUN:   dxil-pc-shadermodel6.3-library %s -O1 -verify
 
 bool test_too_few_arg(bool a) {
   return __builtin_hlsl_and(a);

@mikaelholmen
Copy link
Collaborator

Thank you @Icohedron !

@llvm-beanz llvm-beanz merged commit a6abbe0 into llvm:main Feb 24, 2025
14 checks passed
@damyanp damyanp moved this to Closed in HLSL Support Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category HLSL HLSL Language Support
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

6 participants