[compiler-rt][Darwin][x86] Fix instrprof-darwin-exports test #131425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ld64 issues a warning about section alignment which was counted as an unexpected exported symbol and the test failed. Fixed by disabling all linker warnings using -Wl,-w.
|
@llvm/pr-subscribers-pgo Author: David Tellenbach (dtellenbach) Changesld64 issues a warning about section alignment which was counted as an unexpected exported symbol and the test failed. Fixed by disabling all linker warnings using -Wl,-w. Full diff: https://github.com/llvm/llvm-project/pull/131425.diff 1 Files Affected:
diff --git a/compiler-rt/test/profile/instrprof-darwin-exports.c b/compiler-rt/test/profile/instrprof-darwin-exports.c
index 079d5d28ed24d..1a2ac8c813272 100644
--- a/compiler-rt/test/profile/instrprof-darwin-exports.c
+++ b/compiler-rt/test/profile/instrprof-darwin-exports.c
@@ -7,13 +7,13 @@
// just "_main" produces no warnings or errors.
//
// RUN: echo "_main" > %t.exports
-// RUN: %clang_pgogen -Werror -Wl,-exported_symbols_list,%t.exports -o %t %s 2>&1 | tee %t.log
-// RUN: %clang_profgen -Werror -fcoverage-mapping -Wl,-exported_symbols_list,%t.exports -o %t %s 2>&1 | tee -a %t.log
+// RUN: %clang_pgogen -Werror -Wl,-exported_symbols_list,%t.exports -Wl,-w -o %t %s 2>&1 | tee %t.log
+// RUN: %clang_profgen -Werror -fcoverage-mapping -Wl,-exported_symbols_list,%t.exports -Wl,-w -o %t %s 2>&1 | tee -a %t.log
// RUN: cat %t.log | count 0
// 2) Ditto (1), but for GCOV.
//
-// RUN: %clang -Werror -Wl,-exported_symbols_list,%t.exports --coverage -o %t.gcov %s | tee -a %t.gcov.log
+// RUN: %clang -Werror -Wl,-exported_symbols_list,%t.exports -Wl,-w --coverage -o %t.gcov %s | tee -a %t.gcov.log
// RUN: cat %t.gcov.log | count 0
// 3) The default set of weak external symbols should match the set of symbols
|
|
Failing GreenDragon bot: https://green.lab.llvm.org/job/llvm.org/job/clang-stage1-RA/ |
j-hui
pushed a commit
to j-hui/llvm-project
that referenced
this pull request
Mar 22, 2025
…1425) ld64 issues a warning about section alignment which was counted as an unexpected exported symbol and the test failed. Fixed by disabling all linker warnings using -Wl,-w.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ld64 issues a warning about section alignment which was counted as an unexpected exported symbol and the test failed.
Fixed by disabling all linker warnings using -Wl,-w.