Skip to content

[clang-repl] Handle frontend options for clang-repl before calling executeAction #132670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 48 additions & 1 deletion clang/lib/Interpreter/Interpreter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,48 @@ CreateCI(const llvm::opt::ArgStringList &Argv) {
return std::move(Clang);
}

static llvm::Error HandleFrontendOptions(const CompilerInstance &CI) {
const auto &FrontendOpts = CI.getFrontendOpts();

if (FrontendOpts.ShowHelp) {
driver::getDriverOptTable().printHelp(
llvm::outs(), "clang -cc1 [options] file...",
"LLVM 'Clang' Compiler: http://clang.llvm.org",
/*ShowHidden=*/false, /*ShowAllAliases=*/false,
llvm::opt::Visibility(driver::options::CC1Option));
return llvm::createStringError(llvm::errc::not_supported, "Help displayed");
}

if (FrontendOpts.ShowVersion) {
llvm::cl::PrintVersionMessage();
return llvm::createStringError(llvm::errc::not_supported,
"Version displayed");
}

if (!FrontendOpts.LLVMArgs.empty()) {
unsigned NumArgs = FrontendOpts.LLVMArgs.size();
auto Args = std::make_unique<const char *[]>(NumArgs + 2);
Args[0] = "clang-repl (LLVM option parsing)";
for (unsigned i = 0; i != NumArgs; ++i) {
Args[i + 1] = FrontendOpts.LLVMArgs[i].c_str();
// remove the leading '-' from the option name
if (Args[i + 1][0] == '-') {
auto *option = static_cast<llvm::cl::opt<bool> *>(
llvm::cl::getRegisteredOptions()[Args[i + 1] + 1]);
if (option) {
option->setInitialValue(true);
} else {
llvm::errs() << "Unknown LLVM option: " << Args[i + 1] << "\n";
}
}
}
Args[NumArgs + 1] = nullptr;
llvm::cl::ParseCommandLineOptions(NumArgs + 1, Args.get());
}

return llvm::Error::success();
}

} // anonymous namespace

namespace clang {
Expand Down Expand Up @@ -451,7 +493,12 @@ const char *const Runtimes = R"(

llvm::Expected<std::unique_ptr<Interpreter>>
Interpreter::create(std::unique_ptr<CompilerInstance> CI) {
llvm::Error Err = llvm::Error::success();

llvm::Error Err = HandleFrontendOptions(*CI);
if (Err) {
return std::move(Err);
}

auto Interp =
std::unique_ptr<Interpreter>(new Interpreter(std::move(CI), Err));
if (Err)
Expand Down
5 changes: 5 additions & 0 deletions clang/test/Interpreter/handlefrontendopts.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// RUN: not clang-repl --Xcc -Xclang --Xcc -help 2>&1 | FileCheck %s --check-prefix=HELP
// RUN: not clang-repl --Xcc -Xclang --Xcc -version 2>&1 | FileCheck %s --check-prefix=VERSION

// HELP: Help displayed
// VERSION: Version displayed