[Mips] Guard emission of CFI instructions by MF.needsFrameMoves()
#136108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't emit CFI instructions when they will be skipped by AsmPrinter. Also, use a helper class to simplify emission. As a side effect, this seems to have unblocked delay slot filler optimization on some tests, though it is not obvious to me whether the transformations are legitimate. Similar to llvm#135845 and llvm#136060.
s-barannikov
commented
Apr 17, 2025
| ; GPR: not $[[GPRCC]], $[[GPRCC]] | ||
| ; 32-GPR: bnez $[[GPRCC]], $BB0_2 | ||
| ; 64-GPR: bnezc $[[GPRCC]], .LBB0_2 | ||
| ; 64-GPR: bnez $[[GPRCC]], .LBB0_2 |
There was a problem hiding this comment.
I don't have an explanation for changes in this test. Does this look fine?
There was a problem hiding this comment.
I think it is better to add an explanation.
There was a problem hiding this comment.
Sure, I'll investigate.
|
I'll commit the NFC change separately to simplify the review. |
|
Extracted the NFC part into #136242. I'll let it hang for a couple of days in case there are active reviewers. |
# Conflicts: # llvm/lib/Target/Mips/Mips16FrameLowering.cpp # llvm/lib/Target/Mips/MipsSEFrameLowering.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't emit CFI instructions that will be skipped by AsmPrinter. Also, use a helper class to simplify emission.
As a side effect, this seems to unblock delay slot filler optimization on some tests, though it is not obvious to me whether the transformations are legitimate.
Similar to #135845 and #136060.