[LLVM][Cygwin] Fix shared library name #136599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For clarity, Cygwin currently makes
In order to link one of these, you'd want to use On MSYS2 (which is a fork of Cygwin) the prefix is |
mati865
reviewed
Apr 22, 2025
jeremyd2019
force-pushed
the
llvm-config-cygwin
branch
from
30308d5 to
21e05f7
Compare
jeremyd2019
changed the title
Treat Cygwin like WIN32 in llvm-shlib for naming the library. Don't create shlib symlinks on Cygwin, they don't help anything there, but teach llvm_install_library_symlink that Cygwin's shared libraries live in BINDIR like WIN32. Add a new variable to BuildVariables to have CMake's shared library prefix, to avoid having to patch between "cyg" and "msys-" on MSYS2.
jeremyd2019
force-pushed
the
llvm-config-cygwin
branch
from
21e05f7 to
b092049
Compare
|
After this PR, what you get is
and llvm-config --libs --link-shared returns |
mstorsjo
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
LGTM, this looks reasonable to me, and I don't think we have tests for this kind of output from llvm-config (it's mostly tested by just having someone build things with that configuration somewhere and seeing if it successfully builds or not).
Can merge after a day or so if nobody minds this.
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/130/builds/12816 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2781 Here is the relevant piece of the build log for the reference |
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
May 2, 2025
Treat Cygwin like WIN32 in llvm-shlib for naming the library. Don't create shlib symlinks on Cygwin, they don't help anything there, but teach llvm_install_library_symlink that Cygwin's shared libraries live in BINDIR like WIN32. Add a new variable to llvm-config's BuildVariables to have CMake's shared library prefix, to avoid having to patch between "cyg" and "msys-" on MSYS2.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
May 2, 2025
Treat Cygwin like WIN32 in llvm-shlib for naming the library. Don't create shlib symlinks on Cygwin, they don't help anything there, but teach llvm_install_library_symlink that Cygwin's shared libraries live in BINDIR like WIN32. Add a new variable to llvm-config's BuildVariables to have CMake's shared library prefix, to avoid having to patch between "cyg" and "msys-" on MSYS2.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
May 3, 2025
Treat Cygwin like WIN32 in llvm-shlib for naming the library. Don't create shlib symlinks on Cygwin, they don't help anything there, but teach llvm_install_library_symlink that Cygwin's shared libraries live in BINDIR like WIN32. Add a new variable to llvm-config's BuildVariables to have CMake's shared library prefix, to avoid having to patch between "cyg" and "msys-" on MSYS2.
jeremyd2019
added a commit
to jeremyd2019/llvm-project
that referenced
this pull request
May 5, 2025
Treat Cygwin like WIN32 in llvm-shlib for naming the library. Don't create shlib symlinks on Cygwin, they don't help anything there, but teach llvm_install_library_symlink that Cygwin's shared libraries live in BINDIR like WIN32. Add a new variable to llvm-config's BuildVariables to have CMake's shared library prefix, to avoid having to patch between "cyg" and "msys-" on MSYS2.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Treat Cygwin like WIN32 in llvm-shlib for naming the library. Don't create shlib symlinks on Cygwin, they don't help anything there, but teach llvm_install_library_symlink that Cygwin's shared libraries live in BINDIR like WIN32. Add a new variable to llvm-config's BuildVariables to have CMake's shared library prefix, to avoid having to patch between "cyg" and "msys-" on MSYS2.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Treat Cygwin like WIN32 in llvm-shlib for naming the library. Don't create shlib symlinks on Cygwin, they don't help anything there, but teach llvm_install_library_symlink that Cygwin's shared libraries live in BINDIR like WIN32. Add a new variable to llvm-config's BuildVariables to have CMake's shared library prefix, to avoid having to patch between "cyg" and "msys-" on MSYS2.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Treat Cygwin like WIN32 in llvm-shlib for naming the library. Don't create shlib symlinks on Cygwin, they don't help anything there, but teach llvm_install_library_symlink that Cygwin's shared libraries live in BINDIR like WIN32. Add a new variable to llvm-config's BuildVariables to have CMake's shared library prefix, to avoid having to patch between "cyg" and "msys-" on MSYS2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat Cygwin like WIN32 in llvm-shlib for naming the library.
Don't create shlib symlinks on Cygwin, they don't help anything there, but teach llvm_install_library_symlink that Cygwin's shared libraries live in BINDIR like WIN32.
Add a new variable to llvm-config's BuildVariables to have CMake's shared library prefix, to avoid having to patch between "cyg" and "msys-" on MSYS2.