ValueTracking: Handle minimumnum/maximumnum in canCreateUndefOrPoison

[arsenm]

No description provided.

[arsenm]

• ValueTracking: Handle minimumnum/maximumnum in canCreateUndefOrPoison #138729 👈 (View in Graphite)
• InstCombine: Add baseline test for minimumnum/maximumnum freeze fold #138728
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-llvm-transforms

@llvm/pr-subscribers-llvm-analysis

Author: Matt Arsenault (arsenm)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/138729.diff

2 Files Affected:

• (modified) llvm/lib/Analysis/ValueTracking.cpp (+2)
• (modified) llvm/test/Transforms/InstCombine/freeze-fp-ops.ll (+6-6)

diff --git a/llvm/lib/Analysis/ValueTracking.cpp b/llvm/lib/Analysis/ValueTracking.cpp
index 256e77b40a97f..cdedc65dd48ad 100644
--- a/llvm/lib/Analysis/ValueTracking.cpp
+++ b/llvm/lib/Analysis/ValueTracking.cpp
@@ -7723,6 +7723,8 @@ static bool canCreateUndefOrPoison(const Operator *Op, UndefPoisonKind Kind,
       case Intrinsic::maxnum:
       case Intrinsic::minimum:
       case Intrinsic::maximum:
+      case Intrinsic::minimumnum:
+      case Intrinsic::maximumnum:
       case Intrinsic::is_fpclass:
       case Intrinsic::ldexp:
       case Intrinsic::frexp:
diff --git a/llvm/test/Transforms/InstCombine/freeze-fp-ops.ll b/llvm/test/Transforms/InstCombine/freeze-fp-ops.ll
index 8bee84f23e147..d1a36dcef4d65 100644
--- a/llvm/test/Transforms/InstCombine/freeze-fp-ops.ll
+++ b/llvm/test/Transforms/InstCombine/freeze-fp-ops.ll
@@ -508,9 +508,9 @@ define float @freeze_maximum(float %arg0, float noundef %arg1) {
 
 define float @freeze_minimumnum(float %arg0, float noundef %arg1) {
 ; CHECK-LABEL: @freeze_minimumnum(
-; CHECK-NEXT:    [[OP:%.*]] = call float @llvm.minimumnum.f32(float [[ARG0:%.*]], float noundef [[ARG1:%.*]])
-; CHECK-NEXT:    [[FREEZE:%.*]] = freeze float [[OP]]
-; CHECK-NEXT:    ret float [[FREEZE]]
+; CHECK-NEXT:    [[FREEZE:%.*]] = freeze float [[OP:%.*]]
+; CHECK-NEXT:    [[OP1:%.*]] = call float @llvm.minimumnum.f32(float [[FREEZE]], float noundef [[ARG1:%.*]])
+; CHECK-NEXT:    ret float [[OP1]]
 ;
   %op = call float @llvm.minimumnum.f32(float %arg0, float noundef %arg1)
   %freeze = freeze float %op
@@ -519,9 +519,9 @@ define float @freeze_minimumnum(float %arg0, float noundef %arg1) {
 
 define float @freeze_maximumnum(float %arg0, float noundef %arg1) {
 ; CHECK-LABEL: @freeze_maximumnum(
-; CHECK-NEXT:    [[OP:%.*]] = call float @llvm.maximumnum.f32(float [[ARG0:%.*]], float noundef [[ARG1:%.*]])
-; CHECK-NEXT:    [[FREEZE:%.*]] = freeze float [[OP]]
-; CHECK-NEXT:    ret float [[FREEZE]]
+; CHECK-NEXT:    [[FREEZE:%.*]] = freeze float [[OP:%.*]]
+; CHECK-NEXT:    [[OP1:%.*]] = call float @llvm.maximumnum.f32(float [[FREEZE]], float noundef [[ARG1:%.*]])
+; CHECK-NEXT:    ret float [[OP1]]
 ;
   %op = call float @llvm.maximumnum.f32(float %arg0, float noundef %arg1)
   %freeze = freeze float %op

[nikic]

LGTM

[arsenm]

Merge activity

• May 6, 4:19 PM EDT: A user started a stack merge that includes this pull request via Graphite.
• May 6, 4:25 PM EDT: Graphite rebased this pull request as part of a merge.
• May 6, 4:26 PM EDT: @arsenm merged this pull request with Graphite.