Skip to content

[mlir] Add missing add_mlir_library_install() to tool libraries #140880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

[mlir] Add missing add_mlir_library_install() to tool libraries #140880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mlir/lib/Tools/PDLL/Parser/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@ llvm_add_library(MLIRPDLLParser STATIC
MLIRSupport
MLIRTableGen
)

add_mlir_library_install(MLIRPDLLParser)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of libraries aren't to be installed? Why is this a separate step than llvm_add_library ? Should this be behind a macro we can use everywhere instead of having this separate step?

Copy link
Author

@valgur valgur May 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add_mlir_library() already adds install() commands automatically, but these three specifically use llvm_add_library() instead for whatever reason, which lacks this.
Should they be converted to add_mlir_library(), perhaps?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all the other libs in mlir/lib are using add_mlir_library() then I'm not sure why these aren't indeed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we don't want them in libMLIR.so for some reasons?

2 changes: 2 additions & 0 deletions mlir/lib/Tools/mlir-pdll-lsp-server/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ llvm_add_library(MLIRPdllLspServerLib
MLIRPDLLParser
MLIRLspServerSupportLib
)

add_mlir_library_install(MLIRPdllLspServerLib)
2 changes: 2 additions & 0 deletions mlir/lib/Tools/tblgen-lsp-server/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ llvm_add_library(TableGenLspServerLib
MLIRLspServerSupportLib
MLIRSupport
)

add_mlir_library_install(TableGenLspServerLib)