Skip to content

[clang-doc] Precommit test for global variables #145069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025

Conversation

evelez7
Copy link
Member

@evelez7 evelez7 commented Jun 20, 2025

No description provided.

Copy link
Member Author

evelez7 commented Jun 20, 2025

@evelez7 evelez7 force-pushed the users/evelez7/clang-doc-precommit-globals branch from f572cfc to f056f70 Compare June 20, 2025 21:20
@evelez7 evelez7 force-pushed the users/evelez7/clang-doc-document-concepts branch from 2febdc8 to 63143f0 Compare June 20, 2025 21:20
@evelez7 evelez7 requested review from ilovepi and petrhosek June 20, 2025 21:23
@evelez7 evelez7 marked this pull request as ready for review June 20, 2025 21:23
@llvmbot
Copy link
Member

llvmbot commented Jun 20, 2025

@llvm/pr-subscribers-clang-tools-extra

Author: Erick Velez (evelez7)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/145069.diff

1 Files Affected:

  • (modified) clang-tools-extra/test/clang-doc/json/namespace.cpp (+19-1)
diff --git a/clang-tools-extra/test/clang-doc/json/namespace.cpp b/clang-tools-extra/test/clang-doc/json/namespace.cpp
index 928864be1feb0..248d47351bd38 100644
--- a/clang-tools-extra/test/clang-doc/json/namespace.cpp
+++ b/clang-tools-extra/test/clang-doc/json/namespace.cpp
@@ -103,5 +103,23 @@ typedef int MyTypedef;
 // CHECK-NEXT:      }
 // CHECK-NEXT:    ],
 // CHECK-NEXT:    "USR": "0000000000000000000000000000000000000000"
-// CHECK-NOT:     "Variables": [
+// CHECK-NOT:    "Variables": [
+// CHECK-NOT:      {
+// CHECK-NOT:        "IsStatic": true,
+// CHECK-NOT:        "Location": {
+// CHECK-NOT:          "Filename": "{{.*}}namespace.cpp",
+// CHECK-NOT:          "LineNumber": 13
+// CHECK-NOT:        },
+// CHECK-NOT:        "Name": "Global",
+// CHECK-NOT:        "Type": {
+// COM:                FIXME: IsBuiltIn emits as its default value
+// CHECK-NOT:          "IsBuiltIn": false,
+// CHECK-NOT:          "IsTemplate": false,
+// CHECK-NOT:          "Name": "int",
+// CHECK-NOT:          "QualName": "int",
+// CHECK-NOT:          "USR": "0000000000000000000000000000000000000000"
+// CHECK-NOT:        },
+// CHECK-NOT:        "USR": "{{[0-9A-F]*}}"
+// CHECK-NOT:      }
+// CHECK-NOT:    ]
 // CHECK-NEXT:  }

@evelez7 evelez7 force-pushed the users/evelez7/clang-doc-document-concepts branch from 63143f0 to 00e0bac Compare June 20, 2025 23:40
@evelez7 evelez7 force-pushed the users/evelez7/clang-doc-precommit-globals branch from f056f70 to 62269c9 Compare June 20, 2025 23:40
Base automatically changed from users/evelez7/clang-doc-document-concepts to main June 21, 2025 00:39
@evelez7 evelez7 force-pushed the users/evelez7/clang-doc-precommit-globals branch from 62269c9 to 890d6f9 Compare June 21, 2025 00:41
Copy link
Member Author

evelez7 commented Jun 21, 2025

Merge activity

  • Jun 21, 6:55 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 21, 6:56 PM UTC: @evelez7 merged this pull request with Graphite.

@evelez7 evelez7 merged commit 056b52d into main Jun 21, 2025
7 checks passed
@evelez7 evelez7 deleted the users/evelez7/clang-doc-precommit-globals branch June 21, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants