-
Notifications
You must be signed in to change notification settings - Fork 14.9k
[VectorCombine] Generalize foldBitOpOfBitcasts to support more cast operations #148350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9fc2f3d
[VectorCombine] Generalize foldBitOpOfBitcasts to support more cast o…
rhyadav 56edc81
[VectorCombine] Generalize foldBitOpOfBitcasts to support more cast o…
rhyadav f421a0c
[VectorCombine] Generalize foldBitOpOfBitcasts to support more cast o…
rhyadav 6a16a65
[VectorCombine] Generalize foldBitOpOfBitcasts to support more cast o…
rhyadav 91544ee
[VectorCombine] Generalize foldBitOpOfBitcasts to support more cast o…
rhyadav d650018
fixed the last style issue
rhyadav 3640c96
[VectorCombine] Generalize foldBitOpOfBitcasts to support more cast o…
rhyadav 71abc3f
[VectorCombine] Address review feedback: fix formatting and update tests
rhyadav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we use
IRBuilder<InstSimplifyFolder>
in VectorCombine, the result may point to an existing cast instruction instead ofCastOp (NewOp)
. Therefore, it may propagate flags into an incorrect instruction. I recommend usingCastInst::Create
instead ofBuilder.CreateCast
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dtcxzyw We're already using the Builder::Create* + flags merge approach in a lot of other places in VectorCombine - do you recommend changing those as well? (In a separate patch to this one of course).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. We can propagate the flags in the insert callback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dtcxzyw thanks for catching this, i've made the changes, all tests pass, @RKSimon pls have a look, happy to take on the rest of the changes in VectorCombine in a separate issue/patch.