Skip to content

[CIR] Upstream support for variable template specializations #151069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2025
Merged

[CIR] Upstream support for variable template specializations #151069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9bd371
[CIR] Upstream support for variable template specializations
mmha Aug 6, 2025
6c48451
Add support for partial specializations
mmha Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion clang/lib/CIR/CodeGen/CIRGenModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1307,7 +1307,8 @@ void CIRGenModule::emitTopLevelDecl(Decl *decl) {
}

case Decl::Var:
case Decl::Decomposition: {
case Decl::Decomposition:
case Decl::VarTemplateSpecialization: {
auto *vd = cast<VarDecl>(decl);
if (isa<DecompositionDecl>(decl)) {
errorNYI(decl->getSourceRange(), "global variable decompositions");
Expand Down Expand Up @@ -1342,6 +1343,8 @@ void CIRGenModule::emitTopLevelDecl(Decl *decl) {
case Decl::StaticAssert:
case Decl::TypeAliasTemplate:
case Decl::UsingShadow:
case Decl::VarTemplate:
case Decl::VarTemplatePartialSpecialization:
break;

case Decl::CXXConstructor:
Expand Down
40 changes: 40 additions & 0 deletions clang/test/CIR/CodeGen/variable-template-specialization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// RUN: %clang_cc1 -std=c++14 -triple nvptx64-unknown-unknown -fclangir -emit-cir %s -o %t.cir
// RUN: FileCheck --check-prefix=CIR --input-file=%t.cir %s
// RUN: %clang_cc1 -std=c++14 -triple nvptx64-unknown-unknown -fclangir -emit-llvm %s -o %t-cir.ll
// RUN: FileCheck --check-prefix=LLVM --input-file=%t-cir.ll %s
// RUN: %clang_cc1 -std=c++14 -triple nvptx64-unknown-unknown -emit-llvm %s -o %t.ll
// RUN: FileCheck --check-prefix=OGCG --input-file=%t.ll %s

struct some_struct {
int x;
};

template<int I>
int var_template;

template<> int var_template<0>;
template<> int var_template<1> = 1;
template<> some_struct var_template<2>;

// CIR: !rec_some_struct = !cir.record<struct "some_struct" {!s32i}>
// CIR: cir.global external @_Z12var_templateILi0EE = #cir.int<0> : !s32i
// CIR: cir.global external @_Z12var_templateILi1EE = #cir.int<1> : !s32i
// CIR: cir.global external @_Z12var_templateILi2EE = #cir.zero : !rec_some_struct

// LLVM: %[[STRUCT_TYPE:.+]] = type { i32 }
// LLVM: @_Z12var_templateILi0EE = global i32 0
// LLVM: @_Z12var_templateILi1EE = global i32 1
// LLVM: @_Z12var_templateILi2EE = global %[[STRUCT_TYPE]] zeroinitializer

// OGCG: %[[STRUCT_TYPE:.+]] = type { i32 }
// OGCG: @_Z12var_templateILi0EE = global i32 0
// OGCG: @_Z12var_templateILi1EE = global i32 1
// OGCG: @_Z12var_templateILi2EE = global %[[STRUCT_TYPE]] zeroinitializer

template<typename T, int I> int partial_var_template_specialization_shouldnt_hit_codegen;
template<typename T> int partial_var_template_specialization_shouldnt_hit_codegen<T, 123>;
template<int I> float partial_var_template_specialization_shouldnt_hit_codegen<float, I>;

// CIR-NOT: partial_var_template_specialization_shouldnt_hit_codegen
// LLVM-NOT: partial_var_template_specialization_shouldnt_hit_codegen
// OGCG-NOT: partial_var_template_specialization_shouldnt_hit_codegen