Skip to content

Conversation

ckoparkar
Copy link
Contributor

@ckoparkar ckoparkar commented Jul 30, 2025

Fixes #151314.

/cc @Jezurko

@llvmbot llvmbot added the mlir label Jul 30, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 30, 2025

@llvm/pr-subscribers-mlir

Author: Chaitanya Koparkar (ckoparkar)

Changes

Fixes 151314.

/cc @Jezurko


Full diff: https://github.com/llvm/llvm-project/pull/151315.diff

1 Files Affected:

  • (modified) mlir/docs/DefiningDialects/AttributesAndTypes.md (+1-1)
diff --git a/mlir/docs/DefiningDialects/AttributesAndTypes.md b/mlir/docs/DefiningDialects/AttributesAndTypes.md
index 022bdad9fe512f..b99186391d710a 100644
--- a/mlir/docs/DefiningDialects/AttributesAndTypes.md
+++ b/mlir/docs/DefiningDialects/AttributesAndTypes.md
@@ -136,7 +136,7 @@ def My_IntegerAttr : MyDialect_Attr<"Integer", "int"> {
   /// Here we've defined two parameters, one is a "self" type parameter, and the
   /// other is the integer value of the attribute. The self type parameter is
   /// specially handled by the assembly format.
-  let parameters = (ins AttributeSelfTypeParameter<"">:$type, "APInt":$value);
+  let parameters = (ins AttributeSelfTypeParameter<"">:$type, APIntParameter<"">:$value);
 
   /// Here we've defined a custom builder for the type, that removes the need to pass
   /// in an MLIRContext instance; as it can be infered from the `type`.

@joker-eph joker-eph merged commit 5c87374 into llvm:main Jul 30, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mlir][docs] Out of date code in the tutorial "Adding a new Attribute or Type definition"
3 participants