Skip to content

[Dexter][NFC] Rename step -> step_in #152716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ def launch(self, cmdline):
def _post_step_hook(self):
"""Hook to be executed after completing a step request."""

def step(self):
def step_in(self):
self._flush_breakpoints()
step_req_id = self.send_message(
self.make_request("stepIn", {"threadId": self._debugger_state.thread})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def launch(self):
pass

@abc.abstractmethod
def step(self):
def step_in(self):
pass

@abc.abstractmethod
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def _run_debugger_custom(self, cmdline):
break

if in_source_file(self.source_files, step_info):
self.debugger.step()
self.debugger.step_in()
else:
self.debugger.go()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def launch(self, cmdline):
# We are, by this point, already launched.
self.step_info = probe_process.probe_state(self.client)

def step(self):
def step_in(self):
res = setup.step_once(self.client)
if not res:
self.finished = True
Expand All @@ -122,7 +122,7 @@ def go(self):
# relevant source file -- this is likely to be a problem when setting
# breakpoints. Until that's fixed, single step instead of running
# freely. This isn't very efficient, but at least makes progress.
self.step()
self.step_in()

def _get_step_info(self, watches, step_index):
frames = self.step_info
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ def launch(self, cmdline):
assert num_stopped_threads > 0
assert self._thread, (self._process, self._thread)

def step(self):
def step_in(self):
self._thread.StepInto()
stop_reason = self._thread.GetStopReason()
# If we (1) completed a step and (2) are sitting at a breakpoint,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ def launch(self, cmdline):
self.context.logger.note("Launching VS debugger...")
self._fn_go(False)

def step(self):
def step_in(self):
self._fn_step(False)

def go(self) -> ReturnCode:
Expand Down
Loading