[Dexter] Add DAP stepNext and stepOut support #152717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2025
This was referenced Aug 8, 2025
OCHyams
force-pushed
the
users/OCHyams/dexter-cmds-rename
branch
from
5ae3f45 to
a963080
Compare
OCHyams
force-pushed
the
users/OCHyams/2d54aad7d403
branch
from
73804d1 to
2bb714e
Compare
SLTozer
reviewed
Aug 12, 2025
| ) | ||
| response = self._await_response(step_req_id) | ||
| if not response["success"]: | ||
| raise DebuggerException("failed to step") | ||
| raise DebuggerException(f"failed to {step_request_string}") |
There was a problem hiding this comment.
Slight nit, this message is good if we have stepIn or stepOut, but it may be slightly confusing if a user just gets the exception "failed to next" - maybe make it a little more explicit, like "failed to perform debugger action: '{step_request_string}'"?
|
✅ With the latest revision this PR passed the Python code formatter. |
SLTozer
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.