-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[LLVM][lit] add system-cygwin feature #152780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There are a few tests in clang that gate on system-windows but also don't work on Cygwin, so add a system-cygwin feature for them to use.
@llvm/pr-subscribers-testing-tools Author: None (jeremyd2019) ChangesThere are a few tests in clang that gate on system-windows but also don't work on Cygwin, so add a system-cygwin feature for them to use. Full diff: https://github.com/llvm/llvm-project/pull/152780.diff 1 Files Affected:
diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
index 649636d4bcf4c..b04fb25f3c030 100644
--- a/llvm/utils/lit/lit/llvm/config.py
+++ b/llvm/utils/lit/lit/llvm/config.py
@@ -107,6 +107,8 @@ def __init__(self, lit_config, config):
features.add("system-solaris")
elif platform.system() == "OS/390":
features.add("system-zos")
+ elif sys.platform == "cygwin":
+ features.add("system-cygwin")
# Native compilation: host arch == default triple arch
# Both of these values should probably be in every site config (e.g. as
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There are a few tests in clang that gate on system-windows but also don't work on Cygwin, so add a system-cygwin feature for them to use. (cherry picked from commit 37bcd93)
There are a few tests in clang that gate on system-windows but also don't work on Cygwin, so add a system-cygwin feature for them to use. (cherry picked from commit 37bcd93)
There are a few tests in clang that gate on system-windows but also don't work on Cygwin, so add a system-cygwin feature for them to use. (cherry picked from commit 37bcd93)
There are a few tests in clang that gate on system-windows but also don't work on Cygwin, so add a system-cygwin feature for them to use. (cherry picked from commit 37bcd93)
There are a few tests in clang that gate on system-windows but also don't work on Cygwin, so add a system-cygwin feature for them to use. (cherry picked from commit 37bcd93)
There are a few tests in clang that gate on system-windows but also don't work on Cygwin, so add a system-cygwin feature for them to use. (cherry picked from commit 37bcd93)
There are a few tests in clang that gate on system-windows but also don't work on Cygwin, so add a system-cygwin feature for them to use.