[OpenMP] Update printf stmt in kmp_settings.cpp #152800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extraneous argument from printf statement
jhuber6
reviewed
Aug 11, 2025
| @@ -3280,7 +3280,7 @@ static void __kmp_stg_print_places(kmp_str_buf_t *buffer, char const *name, | |||
| const char *ct_name = __kmp_hw_get_core_type_keyword(ct); | |||
| __kmp_str_buf_print(buffer, ":%s", name, ct_name); | |||
| } else if (eff >= 0 && eff < KMP_HW_MAX_NUM_CORE_EFFS) { | |||
| __kmp_str_buf_print(buffer, ":eff%d", name, eff); | |||
| __kmp_str_buf_print(buffer, ":eff%d", eff); | |||
There was a problem hiding this comment.
This is a little confusing to me, the usage above is the same where we have one printf argument and then the actual thing being printed. Is __kmp_str_buf_print different and takes the extra argument implicitly?
jprotze
reviewed
Aug 12, 2025
Co-authored-by: Joachim <[email protected]>
jhuber6
approved these changes
Aug 14, 2025
mdenson
pushed a commit
to mdenson/llvm-project
that referenced
this pull request
Aug 16, 2025
Remove extraneous argument from printf statement --------- Co-authored-by: Joachim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove extraneous argument from printf statement