Skip to content

[AMDGPU] Encode NV bit in VIMAGE/VSAMPLE. NFC #153654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rampitec
Copy link
Collaborator

This is NFC as this target does not have it.

This is NFC as this target does not have it.
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rampitec rampitec requested a review from shiltian August 14, 2025 19:35
@rampitec rampitec marked this pull request as ready for review August 14, 2025 19:35
@llvmbot
Copy link
Member

llvmbot commented Aug 14, 2025

@llvm/pr-subscribers-backend-amdgpu

Author: Stanislav Mekhanoshin (rampitec)

Changes

This is NFC as this target does not have it.


Full diff: https://github.com/llvm/llvm-project/pull/153654.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AMDGPU/SIInstrFormats.td (+1)
diff --git a/llvm/lib/Target/AMDGPU/SIInstrFormats.td b/llvm/lib/Target/AMDGPU/SIInstrFormats.td
index 89d9b0d32b25b..50964a94d6e58 100644
--- a/llvm/lib/Target/AMDGPU/SIInstrFormats.td
+++ b/llvm/lib/Target/AMDGPU/SIInstrFormats.td
@@ -473,6 +473,7 @@ class VIMAGE_VSAMPLE_Common <bits<8> op> : Enc96 {
   let Inst{4} = r128;
   let Inst{5} = d16;
   let Inst{6} = a16;
+  let Inst{7} = cpol{5}; // nv
   let Inst{21-14} = op;
   let Inst{25-22} = dmask;
   let Inst{39-32} = vdata;

@rampitec rampitec merged commit 6b316ec into main Aug 14, 2025
13 checks passed
@rampitec rampitec deleted the users/rampitec/08-14-_amdgpu_encode_nv_bit_in_vimage_vsample._nfc branch August 14, 2025 20:19
mdenson pushed a commit to mdenson/llvm-project that referenced this pull request Aug 16, 2025
This is NFC as this target does not have it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants