Skip to content

[CAS][Tests] Fix unit tests that hangs on two cores #154151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cachemeifyoucan
Copy link
Collaborator

Reorder the task in the CAS concurrency test so that on low core count,
producer is called before consumer so it won't hang. This can still test
the concurrent behavior on higher core counts.

Created using spr 1.3.6
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cachemeifyoucan cachemeifyoucan merged commit 30c5c48 into main Aug 19, 2025
10 checks passed
@cachemeifyoucan cachemeifyoucan deleted the users/cachemeifyoucan/spr/castests-fix-unit-tests-that-hangs-on-two-cores branch August 19, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants