[lldb] Fix failing test in TestClangREPL #154339
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb Author: Anutosh Bhat (anutosh491) ChangesAddressing #153560 The test runs as expected now Full diff: https://github.com/llvm/llvm-project/pull/154339.diff 1 Files Affected:
diff --git a/lldb/test/API/repl/clang/TestClangREPL.py b/lldb/test/API/repl/clang/TestClangREPL.py
index 3152018865b1e..ffa598b650937 100644
--- a/lldb/test/API/repl/clang/TestClangREPL.py
+++ b/lldb/test/API/repl/clang/TestClangREPL.py
@@ -30,8 +30,9 @@ def start_repl(self):
self.expect("b main", substrs=["Breakpoint 1", "address ="])
self.expect("run", substrs=["stop reason = breakpoint 1"])
- # Start the REPL.
- self.child.send("expression --repl -l c --\n")
+ # Start the REPL with a harmless trailing input to trigger the warning.
+ self.child.send("expression --repl -l c -- 3 + 3\n")
+ self.child.expect_exact("Warning: trailing input is ignored in --repl mode")
self.child.expect_exact("1>")
# PExpect uses many timeouts internally and doesn't play well
@@ -56,16 +57,6 @@ def test_basic_completion(self):
self.quit()
- # Re-enter the REPL with trailing input to trigger warning.
- self.child.send("expression --repl -l c -- 3 + 3\n")
- self.child.expect_exact("Warning: trailing input is ignored in --repl mode\n")
- self.child.expect_exact("1>")
-
- # Evaluate another expression after warning.
- self.expect_repl("4 + 4", substrs=["(int) $3 = 8"])
-
- self.quit()
-
# PExpect uses many timeouts internally and doesn't play well
# under ASAN on a loaded machine..
@skipIfAsan
|
|
Hi @anutosh491 just referencing my comment #153560 (comment) Greendragon must always be green, to make sure we catch any issues that break the tests, I reverted the change in #153560 Please make sure you reland the change with your fix in this current patch (assuming it works) thanks! |
|
Thanks @rastogishubham . I've reapplied the patch ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #153560
The test runs as expected now