Skip to content

Conversation

artagnon
Copy link
Contributor

66be00d ([VPlan] Introduce m_Cmp; match more compares) broke a test: regen it with UTC to fix the build.

66be00d ([VPlan] Introduce m_Cmp; match more compares) broke a test:
regen it with UTC to fix the build.
@llvmbot
Copy link
Member

llvmbot commented Aug 24, 2025

@llvm/pr-subscribers-llvm-transforms

Author: Ramkumar Ramachandra (artagnon)

Changes

66be00d ([VPlan] Introduce m_Cmp; match more compares) broke a test: regen it with UTC to fix the build.


Full diff: https://github.com/llvm/llvm-project/pull/155165.diff

1 Files Affected:

  • (modified) llvm/test/Transforms/LoopVectorize/single-early-exit-interleave-only.ll (+4-8)
diff --git a/llvm/test/Transforms/LoopVectorize/single-early-exit-interleave-only.ll b/llvm/test/Transforms/LoopVectorize/single-early-exit-interleave-only.ll
index 106f159127e6f..64cca5196a8d8 100644
--- a/llvm/test/Transforms/LoopVectorize/single-early-exit-interleave-only.ll
+++ b/llvm/test/Transforms/LoopVectorize/single-early-exit-interleave-only.ll
@@ -19,11 +19,9 @@ define i8 @iv_used_in_exit_with_math(i8 noundef %g) {
 ; CHECK-NEXT:    [[TMP2:%.*]] = shl nuw i8 1, [[TMP0]]
 ; CHECK-NEXT:    [[TMP3:%.*]] = and i8 [[TMP1]], [[G]]
 ; CHECK-NEXT:    [[TMP4:%.*]] = and i8 [[TMP2]], [[G]]
-; CHECK-NEXT:    [[TMP5:%.*]] = icmp eq i8 [[TMP3]], 0
-; CHECK-NEXT:    [[TMP6:%.*]] = icmp eq i8 [[TMP4]], 0
+; CHECK-NEXT:    [[TMP7:%.*]] = icmp ne i8 [[TMP3]], 0
+; CHECK-NEXT:    [[TMP8:%.*]] = icmp ne i8 [[TMP4]], 0
 ; CHECK-NEXT:    [[INDEX_NEXT]] = add nuw i32 [[INDEX]], 2
-; CHECK-NEXT:    [[TMP7:%.*]] = xor i1 [[TMP5]], true
-; CHECK-NEXT:    [[TMP8:%.*]] = xor i1 [[TMP6]], true
 ; CHECK-NEXT:    [[TMP9:%.*]] = or i1 [[TMP7]], [[TMP8]]
 ; CHECK-NEXT:    [[TMP10:%.*]] = icmp eq i32 [[INDEX_NEXT]], 4
 ; CHECK-NEXT:    [[TMP11:%.*]] = or i1 [[TMP9]], [[TMP10]]
@@ -88,11 +86,9 @@ define i32 @iv_used_in_exit_with_loads(ptr align 4 dereferenceable(128) %src) {
 ; CHECK-NEXT:    [[TMP2:%.*]] = getelementptr inbounds i32, ptr [[SRC]], i32 [[TMP0]]
 ; CHECK-NEXT:    [[TMP3:%.*]] = load i32, ptr [[TMP1]], align 4
 ; CHECK-NEXT:    [[TMP4:%.*]] = load i32, ptr [[TMP2]], align 4
-; CHECK-NEXT:    [[TMP5:%.*]] = icmp eq i32 [[TMP3]], 0
-; CHECK-NEXT:    [[TMP6:%.*]] = icmp eq i32 [[TMP4]], 0
+; CHECK-NEXT:    [[TMP7:%.*]] = icmp ne i32 [[TMP3]], 0
+; CHECK-NEXT:    [[TMP8:%.*]] = icmp ne i32 [[TMP4]], 0
 ; CHECK-NEXT:    [[INDEX_NEXT]] = add nuw i32 [[INDEX]], 2
-; CHECK-NEXT:    [[TMP7:%.*]] = xor i1 [[TMP5]], true
-; CHECK-NEXT:    [[TMP8:%.*]] = xor i1 [[TMP6]], true
 ; CHECK-NEXT:    [[TMP9:%.*]] = or i1 [[TMP7]], [[TMP8]]
 ; CHECK-NEXT:    [[TMP10:%.*]] = icmp eq i32 [[INDEX_NEXT]], 32
 ; CHECK-NEXT:    [[TMP11:%.*]] = or i1 [[TMP9]], [[TMP10]]

Copy link
Contributor

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably say update test, not fixing the build

lgtm

@artagnon artagnon changed the title [LV] Fix build after 66be00d [LV] Update test after 66be00d Aug 24, 2025
@artagnon artagnon merged commit 704dee2 into llvm:main Aug 24, 2025
9 of 11 checks passed
@artagnon artagnon deleted the vplan-pm-cmp-fix branch August 24, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants