Skip to content

[mlir][ArmSME] Fix scalable dims check in isValidSMETileVectorType #65254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

c-rhodes
Copy link
Collaborator

@c-rhodes c-rhodes commented Sep 4, 2023

Check for allDimsScalable is incorrect and currently permits fixed vectors.

Check for allDimsScalable is incorrect and currently permits fixed
vectors.
Copy link
Member

@MacDue MacDue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@banach-space banach-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@c-rhodes c-rhodes merged commit 538f135 into llvm:main Sep 5, 2023
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…lvm#65254)

Check for allDimsScalable is incorrect and currently permits fixed
vectors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants