[GitHub] Add main LLVM Dialect path to MLIR LLVM PR subscribers #65513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LLVM Dialect in MLIR, which the `mlir-llvm` team is supposed to provide notifications for, is 98% not nested in a directory called LLVM but rather LLVMIR. The former only contains some tests. This should make PRs such as llvm#65508 add the team as codeowner.
joker-eph
reviewed
Sep 6, 2023
.github/CODEOWNERS
Outdated
| @@ -120,6 +120,7 @@ | |||
|
|
|||
| # mlir-llvm | |||
| /mlir/**/LLVM/ @llvm/pr-subscribers-mlir-llvm | |||
There was a problem hiding this comment.
Shall we just remove the trailing / here?
There was a problem hiding this comment.
Just tested this using git check-ignore (since this should be the same syntax as for the codeowners file apparently) and that at least did not work for any checks in the LLVMIR directory.
Changing it to either LLVMIR with or without the slash works, but it seems to me like it doesn't treat trailing positions specially.
Unless GitHub CodeOwners files do it differently.
There was a problem hiding this comment.
OK! We need a trailing *, which means most of the existing patterns are incorrect...
mlir/**/LLVM* should match both here.
joker-eph
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LLVM Dialect in MLIR, which the
mlir-llvmteam is supposed to provide notifications for, is 98% not nested in a directory called LLVM but rather LLVMIR. The former only contains some tests.This should make PRs such as #65508 add the team as codeowner.