[libc++] Update Apple CI jobs to run the C++23 configuration #66367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were running the test suite in C++20 mode, but we should really be tracking the latest supported version. We can't do C++26 because the latest stable AppleClang doesn't support it yet.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx ChangesWe were running the test suite in C++20 mode, but we should really be tracking the latest supported version. We can't do C++26 because the latest stable AppleClang doesn't support it yet. -- Full diff: https://github.com//pull/66367.diff1 Files Affected:
diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml
index 90bb343f7c7ad03..f2329457c7bd938 100644
--- a/libcxx/utils/ci/buildkite-pipeline.yml
+++ b/libcxx/utils/ci/buildkite-pipeline.yml
@@ -908,7 +908,7 @@ steps:
- group: ":mac: Apple"
steps:
- label: "MacOS x86_64"
- command: "libcxx/utils/ci/run-buildbot generic-cxx20"
+ command: "libcxx/utils/ci/run-buildbot generic-cxx23"
artifact_paths:
- "**/test-results.xml"
- "**/*.abilist"
@@ -923,7 +923,7 @@ steps:
timeout_in_minutes: 120
- label: "MacOS arm64"
- command: "libcxx/utils/ci/run-buildbot generic-cxx20"
+ command: "libcxx/utils/ci/run-buildbot generic-cxx23"
artifact_paths:
- "**/test-results.xml"
- "**/*.abilist"
|
philnik777
approved these changes
Sep 14, 2023
mordante
approved these changes
Sep 15, 2023
|
The CI failure was on Windows and looks clearly unrelated. |
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running the test suite in C++20 mode, but we should really be tracking the latest supported version. We can't do C++26 because the latest stable AppleClang doesn't support it yet.