[builtins][NFC] Avoid using CRT_LDBL_128BIT in tests #66832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://reviews.llvm.org/D153812 removed this macro from implementations. Clean this up from tests as well.
compnerd
approved these changes
Sep 19, 2023
alexander-shaposhnikov
approved these changes
Sep 19, 2023
This was referenced Sep 20, 2023
arichardson
reviewed
Oct 3, 2023
| @@ -7,7 +7,7 @@ | |||
| #include <float.h> | |||
| #include <stdio.h> | |||
|
|
|||
| #if defined(CRT_HAS_128BIT) && defined(CRT_LDBL_128BIT) | |||
| #if defined(CRT_HAS_TF_MODE) | |||
There was a problem hiding this comment.
This one actually fails without an IEEE float128. Right now that doesn't matter but it will start failing once CRT_HAS_TF_MODE gets set with non-IEEE TF floats (powerpc64).
There was a problem hiding this comment.
Correct guard added in #68132.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://reviews.llvm.org/D153812 removed this macro from implementations. Clean this up from tests as well.