Skip to content

[libc++] LWG 3821 uses_allocator_construction_args should have overload for pair-like #66939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2023
Merged

[libc++] LWG 3821 uses_allocator_construction_args should have overload for pair-like #66939

merged 5 commits into from
Oct 9, 2023

Conversation

huixie90
Copy link
Contributor

@huixie90 huixie90 commented Sep 20, 2023 •
edited
Loading

This change addresses LWG 3821 and LWG 3677.

  • make std::pair's constructor no longer takes subrange
  • uses_allocator_construction_args constraint changes w.r.t to pair-like types
  • uses_allocator_construction_args constraints checks is-pair-like<remove_cv_t<T>>

@huixie90 huixie90 requested a review from a team as a code owner September 20, 2023 18:42
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Sep 20, 2023
@ldionne ldionne self-assigned this Sep 21, 2023
@ldionne ldionne mentioned this pull request Sep 27, 2023
Merged
ldionne
ldionne approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI! You'll need to remove libcxx/test/std/utilities/memory/allocator.uses/allocator.uses.construction/uses_allocator_construction_args.pass.cpp from the ignore_format.txt file since it's properly formatted now.

@ldionne
Copy link
Member

ldionne commented Oct 4, 2023

LGTM. Please squash and merge once CI is green.

@huixie90 huixie90 merged commit bcf172e into llvm:main Oct 9, 2023
@stepthomas stepthomas mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philnik777 philnik777 philnik777 left review comments

@ldionne ldionne ldionne approved these changes

Assignees

@ldionne ldionne

Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huixie90 @ldionne @philnik777 @llvmbot