Skip to content

[X86] fix combineSubSetcc to handle a large constant #66941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2023
Merged

[X86] fix combineSubSetcc to handle a large constant #66941

merged 1 commit into from
Sep 20, 2023

Conversation

mizvekov
Copy link
Contributor

No description provided.

@mizvekov mizvekov self-assigned this Sep 20, 2023
RKSimon
RKSimon approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@RKSimon RKSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mizvekov mizvekov merged commit 8b04f1e into llvm:main Sep 20, 2023
@kstoimenov kstoimenov mentioned this pull request Sep 22, 2023
Closed
@mizvekov mizvekov deleted the fix_x86_combineSubSetcc_apint branch September 29, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RKSimon RKSimon RKSimon approved these changes

@kazutakahirata kazutakahirata Awaiting requested review from kazutakahirata

@phoebewang phoebewang Awaiting requested review from phoebewang

Assignees

@mizvekov mizvekov

Labels
backend:X86
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mizvekov @RKSimon @llvmbot