[Clang][Driver] Add new flags to control IR verification #68172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizvekov
added
the
clang:driver
mizvekov
changed the title
mizvekov
force-pushed
the
clang_no-disable-llvm-verifier
branch
3 times, most recently
from
8a02263 to
634c0f8
Compare
nikic
reviewed
Oct 4, 2023
mizvekov
force-pushed
the
clang_no-disable-llvm-verifier
branch
from
634c0f8 to
a5414db
Compare
aeubanks
approved these changes
Oct 4, 2023
fhahn
reviewed
Oct 5, 2023
| @@ -5150,9 +5150,11 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, | |||
| const bool IsAssertBuild = true; | |||
| #endif | |||
|
|
|||
| // Disable the verification pass in -asserts builds. | |||
There was a problem hiding this comment.
Hmm, I might be missing something here, but doesn't this disable the verifier for builds without assertions?
There was a problem hiding this comment.
I edited the line to append the unless otherwise specified, since now we allow overriding that with the new flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables or disables verification of the generated LLVM IR.
Users can pass this to turn on extra verification to catch certain types of
compiler bugs at the cost of extra compile time.