Skip to content

[lldb][FreeBSD] fix i386 size_t error when using LLDB_LOGF #68210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2023
Merged

[lldb][FreeBSD] fix i386 size_t error when using LLDB_LOGF #68210

merged 1 commit into from
Oct 4, 2023

Conversation

aokblast
Copy link
Contributor

@aokblast aokblast commented Oct 4, 2023

No description provided.

@llvmbot llvmbot added the lldb label Oct 4, 2023
@aokblast aokblast mentioned this pull request Oct 4, 2023
Merged
DavidSpickett
DavidSpickett approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%zu is used a lot elsewhere for logs and prints, none of which I've seen warn across Linaro's bots. So this LGTM, thanks for the fix.

@emaste emaste merged commit e00f227 into llvm:main Oct 4, 2023
@DavidSpickett
Copy link
Collaborator

No warning present in https://lab.llvm.org/buildbot/#/builders/17/builds/44083 or https://lab.llvm.org/buildbot/#/builders/219/builds/6093. So this worked.

@stepthomas stepthomas mentioned this pull request Oct 10, 2023
Closed
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Oct 12, 2023
Merged main:e00f2272d640 into amd-gfx:7a55dcafa40e
a86283a 
Local branch amd-gfx 7a55dca Merged main:9f406e450b6d into amd-gfx:7e7cb7e72c63
Remote branch main e00f227 [lldb][FreeBSD] fix i386 size_t error when using LLDB_LOGF (llvm#68210)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidSpickett DavidSpickett DavidSpickett approved these changes

Assignees
No one assigned
Labels
lldb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aokblast @DavidSpickett @emaste @llvmbot