[Libomptarget] Explicitly pass the OpenMP device libraries to tests #68225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We have tests that depend on two static libraries `libomptarget.devicertl.a` and `libcgpu.a`. These are currently implicitly picked up and searched through the standard path. This patch changes that to pass `-nogpulib` to disable implicit runtime path searches. We then explicitly passed the built libraries to the compilations so that we know exactly which libraries are being used. Depends on: llvm#68220
|
An irrelevant question: can GitHub handle dependence? |
No, that's just for me to keep track as I made three separate patches. There's still an ongoing discussion on how to handle stacked revisions. |
shiltian
approved these changes
Oct 4, 2023
JonChesterfield
approved these changes
Oct 4, 2023
Merged
qihangkong
pushed a commit
to rvgpu/llvm
that referenced
this pull request
Apr 18, 2024
…tests This pull request is a follow-up of patch: llvm/llvm-project#68225 and it explicitly specifies OpenMP device libraries for Fortran OpenMP tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have tests that depend on two static libraries
libomptarget.devicertl.aandlibcgpu.a. These are currentlyimplicitly picked up and searched through the standard path. This patch
changes that to pass
-nogpulibto disable implicit runtime pathsearches. We then explicitly passed the built libraries to the
compilations so that we know exactly which libraries are being used.
Depends on: #68220
Fixes #68141