[mlir][sparse] simplify ConvertOp rewriting rules #68350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeimingLiu
commented
Oct 5, 2023
mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_foreach_slices.mlir
Outdated
Show resolved
Hide resolved
mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_matmul_slice.mlir
Outdated
Show resolved
Hide resolved
PeimingLiu
force-pushed
the
peiming-clean
branch
5 times, most recently
from
d02a1a2 to
2f43a47
Compare
aartbik
reviewed
Oct 6, 2023
PeimingLiu
force-pushed
the
peiming-clean
branch
3 times, most recently
from
b0c7d18 to
3a4af91
Compare
aartbik
approved these changes
Oct 11, 2023
added 8 commits
October 11, 2023 16:15
yinying-lisa-li
approved these changes
Oct 11, 2023
PeimingLiu
force-pushed
the
peiming-clean
branch
from
3a4af91 to
4fc4741
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canonicalize complex convertOp into multiple stages, such that it can either be done by a direct conversion or by sorting.