WIP: [flang] Enable fir alias tags pass by default when optimizing for speed #68597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tblah
requested review from
kiranchandramohan,
Renaud-K,
vzakhari and
victorkingi
tblah
changed the title
|
Hi @tblah, is this ready for a merge? Let me know if you are just waiting for a review. |
|
Hi @vzakhari, currently there is a serious performance regression in spec2017 exchange2. With the TBAA tags we produce slightly better code (less repeated loads, hoisting some code out of loops, etc). Unfortunately, this change to the generated code causes LLVM's function specialization pass to incorrectly judge that specialization will not be profitable, leading to the large performance regression. @Leporacanthicus is working on this now. If you're happy, I think we can enable the tbaa tags by default after that. |
Enable by default when optimizing for speed. For simplicity, only forward the flag to the frontend driver when it contradicts what is implied by the optimization level.
tblah
force-pushed
the
ecclescake/tbaa-squashed
branch
from
0810f90 to
6000017
Compare
|
Sorry for the noise all. Closing and re-creating to avoid pinging everyone with review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable by default when optimizing for speed.
Previous PR in this series: #68595
This PR is only for review of 0810f90041bb7ece83510193db6c420bb679f22a (and any fixups)
This is WIP until performance regressions due to the TBAA tags are resolved.